Page MenuHomePhabricator
Differential D12602

[web] fix colors in calendar history modal
ClosedPublic
Actions

Authored by ginsu on Jun 27 2024, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 6:04 PM
Unknown Object (File)
Thu, Sep 26, 6:02 PM
Unknown Object (File)
Wed, Sep 25, 5:29 AM
Unknown Object (File)
Tue, Sep 17, 3:01 AM
Unknown Object (File)
Mon, Sep 16, 10:38 AM
Unknown Object (File)
Mon, Sep 16, 8:52 AM
Unknown Object (File)
Sat, Sep 14, 10:48 PM
Unknown Object (File)
Sat, Sep 14, 5:47 PM
View All 57 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMMfc09fb873d01: [web] fix colors in calendar history modal
Summary

This diff fixes the colors in the calendar history modal

Linear task: https://linear.app/comm/issue/ENG-8355/convert-calendary-history-modal-on-web-to-dark-mode

Test Plan

Please see the screenshots below

Before:

Screenshot 2024-06-27 at 9.09.43 PM.png (2×3 px, 797 KB)

After:

Screenshot 2024-07-02 at 1.00.31 AM.png (2×3 px, 775 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-8010 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 27 2024, 6:47 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2024, 6:47 PM
ginsu edited the summary of this revision. (Show Details)Jun 27 2024, 6:50 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: inka.
ginsu attached a referenced file: F2131600: Screenshot 2024-06-27 at 9.49.24 PM.png. (Show Details)
ginsu attached a referenced file: F2131597: Screenshot 2024-06-27 at 9.09.43 PM.png. (Show Details)
Harbormaster completed remote builds in B29979: Diff 41778.Jun 27 2024, 7:05 PM
ginsu requested review of this revision.Jun 27 2024, 7:05 PM
ashoat accepted this revision.Jul 1 2024, 1:23 PM

Huge improvement! In the old design, the background for "June 1" was different than the background for the rest. Do you think we can preserve that here?

This revision is now accepted and ready to land.Jul 1 2024, 1:23 PM
ginsu updated this revision to Diff 41870.Jul 1 2024, 10:01 PM

address comments

ginsu edited the test plan for this revision. (Show Details)Jul 1 2024, 10:05 PM
ginsu attached a referenced file: F2163971: Screenshot 2024-07-02 at 1.00.31 AM.png. (Show Details)
Harbormaster completed remote builds in B30040: Diff 41870.Jul 1 2024, 10:18 PM
Closed by commit rCOMMfc09fb873d01: [web] fix colors in calendar history modal (authored by ginsu). · Explain WhyJul 2 2024, 1:46 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfc09fb873d01: [web] fix colors in calendar history modal.

Revision Contents
Changeset List

PathSize
web/
modals/
history/
14 lines

Diff 41778

View Options

web/modals/history/history.css

Loading...