Page MenuHomePhabricator
Differential D12684

[landing/lib/native/web] update copy for thread notifications for the rest of the app
ClosedPublic
Actions

Authored by ginsu on Jul 8 2024, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:50 PM
Unknown Object (File)
Sun, Nov 10, 4:44 PM
Unknown Object (File)
Sun, Nov 10, 8:41 AM
Unknown Object (File)
Sun, Nov 10, 8:41 AM
Unknown Object (File)
Sun, Nov 10, 8:08 AM
Unknown Object (File)
Sat, Nov 9, 3:05 PM
Unknown Object (File)
Sat, Nov 9, 12:15 PM
Unknown Object (File)
Sat, Nov 9, 11:05 AM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of…
Summary

This diff updates the rest of the copy from "focused" => "home" and "background" => "muted"

Linear task: https://linear.app/comm/issue/ENG-8455/rename-focused-to-home-and-background-to-muted

Test Plan

flow + please see the screenshots below

Screenshot 2024-07-08 at 3.14.10 AM.png (1×1 px, 872 KB)

Screenshot 2024-07-08 at 3.17.14 AM.png (1×1 px, 494 KB)

Screenshot 2024-07-08 at 3.13.35 AM.png (370×884 px, 28 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 8 2024, 12:10 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 8 2024, 12:11 AM
ginsu edited the test plan for this revision. (Show Details)Jul 8 2024, 12:17 AM
ginsu added reviewers: ashoat, inka.
ginsu attached a referenced file: F2210836: Screenshot 2024-07-08 at 3.13.35 AM.png. (Show Details)
ginsu attached a referenced file: F2210837: Screenshot 2024-07-08 at 3.17.14 AM.png. (Show Details)
ginsu attached a referenced file: F2210838: Screenshot 2024-07-08 at 3.14.10 AM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B30183: Diff 42095.Jul 8 2024, 12:31 AM
ginsu requested review of this revision.Jul 8 2024, 12:31 AM
ginsu added inline comments.Jul 8 2024, 12:42 AM
native/profile/default-notifications-preferences.react.js
159

This notificationTypes object is used with communication between the client + keyserver, so to ensure that I didn't cause any regressions I just left this as is

inka accepted this revision.Jul 8 2024, 4:46 AM
This revision is now accepted and ready to land.Jul 8 2024, 4:46 AM
ginsu added 1 blocking reviewer(s): ashoat.Jul 8 2024, 11:03 AM

Making @ashoat blocking since this is a copy change diff

This revision now requires review to proceed.Jul 8 2024, 11:03 AM
ashoat accepted this revision.Jul 8 2024, 12:44 PM

Looks like threadSettingsNotificationsCopy has already been updated

landing/competitor-data.js
184

Thanks for updating this stuff!

This revision is now accepted and ready to land.Jul 8 2024, 12:44 PM
ginsu updated this revision to Diff 42126.Jul 8 2024, 12:54 PM

rebase before landing

ginsu retitled this revision from [landing] update copy for thread notifications on landing to [landing/lib/native/web] update copy for thread notifications for the rest of the app.Jul 8 2024, 12:54 PM
This revision was landed with ongoing or failed builds.Jul 8 2024, 12:56 PM
Closed by commit rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of….
Harbormaster completed remote builds in B30208: Diff 42126.Jul 8 2024, 1:10 PM

Revision Contents
Changeset List

Diff 42095

View Options

landing/competitor-data.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/background-chat-thread-list.react.js

Loading...
View Options

native/chat/chat.react.js

Loading...
View Options

native/profile/default-notifications-preferences.react.js

Loading...
View Options

web/chat/chat-tabs.react.js

Loading...
View Options

web/chat/chat-thread-list.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...