native/profile/default-notifications-preferences.react.js
159 ↗	(On Diff #42095)	This `notificationTypes` object is used with communication between the client + keyserver, so to ensure that I didn't cause any regressions I just left this as is

inka accepted this revision.Jul 8 2024, 4:46 AM

This revision is now accepted and ready to land.Jul 8 2024, 4:46 AM

Making @ashoat blocking since this is a copy change diff

This revision now requires review to proceed.Jul 8 2024, 11:03 AM

Looks like threadSettingsNotificationsCopy has already been updated

landing/competitor-data.js
184 ↗	(On Diff #42095)	Thanks for updating this stuff!

This revision is now accepted and ready to land.Jul 8 2024, 12:44 PM

rebase before landing

ginsu retitled this revision from [landing] update copy for thread notifications on landing to [landing/lib/native/web] update copy for thread notifications for the rest of the app.Jul 8 2024, 12:54 PM

This revision was landed with ongoing or failed builds.Jul 8 2024, 12:56 PM

Closed by commit rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of… (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of….

Harbormaster completed remote builds in B30208: Diff 42126.Jul 8 2024, 1:10 PM

Revision Contents
Changeset List

Path

Size

landing/

competitor-data.js

16 lines

lib/

shared/

thread-utils.js

4 lines

native/

chat/

background-chat-thread-list.react.js

3 lines

chat.react.js

4 lines

profile/

default-notifications-preferences.react.js

7 lines

web/

chat/

chat-tabs.react.js

17 lines

chat-thread-list.react.js

6 lines

thread-list-provider.js

14 lines

Diff 42128

View Options

landing/competitor-data.js

use crate::{		use crate::{
handle_string_result_as_callback, handle_void_result_as_callback, Error,		handle_string_result_as_callback, handle_void_result_as_callback, Error,
CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,		CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,
};		};
use grpc_clients::identity::{		use grpc_clients::identity::{
get_auth_client, get_unauthenticated_client,		get_auth_client, get_unauthenticated_client,
protos::auth::LinkFarcasterAccountRequest,		protos::auth::LinkFarcasterAccountRequest, protos::unauth::Empty,
protos::unauth::GetFarcasterUsersRequest,		protos::unauth::GetFarcasterUsersRequest,
};		};
use serde::Serialize;		use serde::Serialize;

#[derive(Serialize)]		#[derive(Serialize)]
#[serde(rename_all = "camelCase")]		#[serde(rename_all = "camelCase")]
struct FarcasterUser {		struct FarcasterUser {
#[serde(rename = "userID")]		#[serde(rename = "userID")]
▲ Show 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	let link_farcaster_account_request =
LinkFarcasterAccountRequest { farcaster_id };		LinkFarcasterAccountRequest { farcaster_id };

identity_client		identity_client
.link_farcaster_account(link_farcaster_account_request)		.link_farcaster_account(link_farcaster_account_request)
.await?;		.await?;

Ok(())		Ok(())
}		}

		pub fn unlink_farcaster_account(
		user_id: String,
		device_id: String,
		access_token: String,
		promise_id: u32,
		) {
		RUNTIME.spawn(async move {
		let result =
		unlink_farcaster_account_helper(user_id, device_id, access_token).await;
		handle_void_result_as_callback(result, promise_id);
		});
		}

		async fn unlink_farcaster_account_helper(
		user_id: String,
		device_id: String,
		access_token: String,
		) -> Result<(), Error> {
		let mut identity_client = get_auth_client(
		IDENTITY_SOCKET_ADDR,
		user_id,
		device_id,
		access_token,
		CODE_VERSION,
		DEVICE_TYPE.as_str_name().to_lowercase(),
		)
		.await?;

		identity_client.unlink_farcaster_account(Empty {}).await?;

		Ok(())
		}

View Options

lib/shared/thread-utils.js

use crate::{		use crate::{
handle_string_result_as_callback, handle_void_result_as_callback, Error,		handle_string_result_as_callback, handle_void_result_as_callback, Error,
CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,		CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,
};		};
use grpc_clients::identity::{		use grpc_clients::identity::{
get_auth_client, get_unauthenticated_client,		get_auth_client, get_unauthenticated_client,
protos::auth::LinkFarcasterAccountRequest,		protos::auth::LinkFarcasterAccountRequest, protos::unauth::Empty,
protos::unauth::GetFarcasterUsersRequest,		protos::unauth::GetFarcasterUsersRequest,
};		};
use serde::Serialize;		use serde::Serialize;

#[derive(Serialize)]		#[derive(Serialize)]
#[serde(rename_all = "camelCase")]		#[serde(rename_all = "camelCase")]
struct FarcasterUser {		struct FarcasterUser {
#[serde(rename = "userID")]		#[serde(rename = "userID")]
▲ Show 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	let link_farcaster_account_request =
LinkFarcasterAccountRequest { farcaster_id };		LinkFarcasterAccountRequest { farcaster_id };

identity_client		identity_client
.link_farcaster_account(link_farcaster_account_request)		.link_farcaster_account(link_farcaster_account_request)
.await?;		.await?;

Ok(())		Ok(())
}		}

		pub fn unlink_farcaster_account(
		user_id: String,
		device_id: String,
		access_token: String,
		promise_id: u32,
		) {
		RUNTIME.spawn(async move {
		let result =
		unlink_farcaster_account_helper(user_id, device_id, access_token).await;
		handle_void_result_as_callback(result, promise_id);
		});
		}

		async fn unlink_farcaster_account_helper(
		user_id: String,
		device_id: String,
		access_token: String,
		) -> Result<(), Error> {
		let mut identity_client = get_auth_client(
		IDENTITY_SOCKET_ADDR,
		user_id,
		device_id,
		access_token,
		CODE_VERSION,
		DEVICE_TYPE.as_str_name().to_lowercase(),
		)
		.await?;

		identity_client.unlink_farcaster_account(Empty {}).await?;

		Ok(())
		}

View Options

native/chat/background-chat-thread-list.react.js

use crate::{		use crate::{
handle_string_result_as_callback, handle_void_result_as_callback, Error,		handle_string_result_as_callback, handle_void_result_as_callback, Error,
CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,		CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,
};		};
use grpc_clients::identity::{		use grpc_clients::identity::{
get_auth_client, get_unauthenticated_client,		get_auth_client, get_unauthenticated_client,
protos::auth::LinkFarcasterAccountRequest,		protos::auth::LinkFarcasterAccountRequest, protos::unauth::Empty,
protos::unauth::GetFarcasterUsersRequest,		protos::unauth::GetFarcasterUsersRequest,
};		};
use serde::Serialize;		use serde::Serialize;

#[derive(Serialize)]		#[derive(Serialize)]
#[serde(rename_all = "camelCase")]		#[serde(rename_all = "camelCase")]
struct FarcasterUser {		struct FarcasterUser {
#[serde(rename = "userID")]		#[serde(rename = "userID")]
▲ Show 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	let link_farcaster_account_request =
LinkFarcasterAccountRequest { farcaster_id };		LinkFarcasterAccountRequest { farcaster_id };

identity_client		identity_client
.link_farcaster_account(link_farcaster_account_request)		.link_farcaster_account(link_farcaster_account_request)
.await?;		.await?;

Ok(())		Ok(())
}		}

		pub fn unlink_farcaster_account(
		user_id: String,
		device_id: String,
		access_token: String,
		promise_id: u32,
		) {
		RUNTIME.spawn(async move {
		let result =
		unlink_farcaster_account_helper(user_id, device_id, access_token).await;
		handle_void_result_as_callback(result, promise_id);
		});
		}

		async fn unlink_farcaster_account_helper(
		user_id: String,
		device_id: String,
		access_token: String,
		) -> Result<(), Error> {
		let mut identity_client = get_auth_client(
		IDENTITY_SOCKET_ADDR,
		user_id,
		device_id,
		access_token,
		CODE_VERSION,
		DEVICE_TYPE.as_str_name().to_lowercase(),
		)
		.await?;

		identity_client.unlink_farcaster_account(Empty {}).await?;

		Ok(())
		}

View Options

native/chat/chat.react.js

use crate::{		use crate::{
handle_string_result_as_callback, handle_void_result_as_callback, Error,		handle_string_result_as_callback, handle_void_result_as_callback, Error,
CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,		CODE_VERSION, DEVICE_TYPE, IDENTITY_SOCKET_ADDR, RUNTIME,
};		};
use grpc_clients::identity::{		use grpc_clients::identity::{
get_auth_client, get_unauthenticated_client,		get_auth_client, get_unauthenticated_client,
protos::auth::LinkFarcasterAccountRequest,		protos::auth::LinkFarcasterAccountRequest, protos::unauth::Empty,
protos::unauth::GetFarcasterUsersRequest,		protos::unauth::GetFarcasterUsersRequest,
};		};
use serde::Serialize;		use serde::Serialize;

#[derive(Serialize)]		#[derive(Serialize)]
#[serde(rename_all = "camelCase")]		#[serde(rename_all = "camelCase")]
struct FarcasterUser {		struct FarcasterUser {
#[serde(rename = "userID")]		#[serde(rename = "userID")]
▲ Show 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	let link_farcaster_account_request =
LinkFarcasterAccountRequest { farcaster_id };		LinkFarcasterAccountRequest { farcaster_id };

identity_client		identity_client
.link_farcaster_account(link_farcaster_account_request)		.link_farcaster_account(link_farcaster_account_request)
.await?;		.await?;

Ok(())		Ok(())
}		}

		pub fn unlink_farcaster_account(
		user_id: String,
		device_id: String,
		access_token: String,
		promise_id: u32,
		) {
		RUNTIME.spawn(async move {
		let result =
		unlink_farcaster_account_helper(user_id, device_id, access_token).await;
		handle_void_result_as_callback(result, promise_id);
		});
		}

		async fn unlink_farcaster_account_helper(
		user_id: String,
		device_id: String,
		access_token: String,
		) -> Result<(), Error> {
		let mut identity_client = get_auth_client(
		IDENTITY_SOCKET_ADDR,
		user_id,
		device_id,
		access_token,
		CODE_VERSION,
		DEVICE_TYPE.as_str_name().to_lowercase(),
		)
		.await?;

		identity_client.unlink_farcaster_account(Empty {}).await?;

		Ok(())
		}