Details

Reviewers

atul
ashoat

Commits

rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only

Summary

This differential narrows the scope of on-the-client notif generation code to operate on thick threads only.

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jul 17 2024, 1:04 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 17 2024, 1:04 PM

Harbormaster completed remote builds in B30411: Diff 42382.Jul 17 2024, 1:21 PM

marcin requested review of this revision.Jul 17 2024, 1:21 PM

ashoat accepted this revision.Jul 17 2024, 1:22 PM

This revision is now accepted and ready to land.Jul 17 2024, 1:22 PM

Rebase before landing

Harbormaster completed remote builds in B30424: Diff 42396.Jul 17 2024, 5:50 PM

Rebase before landing

Harbormaster failed remote builds in B30426: Diff 42399!Jul 17 2024, 6:01 PM

Rebase before landing

This revision was landed with ongoing or failed builds.Jul 18 2024, 8:41 AM

Closed by commit rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only. · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only.

Harbormaster completed remote builds in B30456: Diff 42454.Jul 18 2024, 8:56 AM

ashoat mentioned this in D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 18 2024, 5:17 PM

Make client notif generation code operate on thick threads only
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42455

lib/push/send-hooks.react.js

lib/push/send-utils.js

lib/selectors/thread-selectors.js

lib/types/thread-types.js

Make client notif generation code operate on thick threads onlyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42455

lib/push/send-hooks.react.js

lib/push/send-utils.js

lib/selectors/thread-selectors.js

lib/types/thread-types.js

Make client notif generation code operate on thick threads only
ClosedPublic
Actions

Revision Contents
Changeset List