Differential D12799

[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`
ClosedPublic
Actions

Authored by atul on Jul 18 2024, 2:48 PM.

Details

Reviewers

ashoat

Commits

rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->…

Summary

Based on feedback here: https://phab.comm.dev/D12779?id=42418#inline-74380

Test Plan

NA, simple rename using IDE refactor feature.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jul 18 2024, 2:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 18 2024, 2:48 PM

atul mentioned this in D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.Jul 18 2024, 2:48 PM

Harbormaster completed remote builds in B30497: Diff 42505.Jul 18 2024, 3:04 PM

atul requested review of this revision.Jul 18 2024, 3:04 PM

ashoat accepted this revision.Jul 18 2024, 4:37 PM

This revision is now accepted and ready to land.Jul 18 2024, 4:37 PM

rebase and land

This revision was landed with ongoing or failed builds.Jul 19 2024, 4:36 PM

Closed by commit rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->….

Harbormaster completed remote builds in B30526: Diff 42561.Jul 19 2024, 4:45 PM

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions.test.js

10 lines

shared/

redux/

deprecated-update-roles-and-permissions.js

4 lines

thread-utils.js

4 lines

types/

minimally-encoded-thread-permissions-types.js

4 lines

native/

redux/

persist.js

4 lines

Diff 42505

View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

View Options

lib/shared/redux/deprecated-update-roles-and-permissions.js

View Options

lib/shared/thread-utils.js

View Options

lib/types/minimally-encoded-thread-permissions-types.js

View Options

[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42505

lib/permissions/minimally-encoded-thread-permissions.test.js

lib/shared/redux/deprecated-update-roles-and-permissions.js

lib/shared/thread-utils.js

lib/types/minimally-encoded-thread-permissions-types.js

native/redux/persist.js

[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`
ClosedPublic
Actions

Revision Contents
Changeset List