Page MenuHomePhabricator
Differential D12804

[native][web] Rename P2P messages methods
ClosedPublic
Actions

Authored by tomek on Jul 19 2024, 8:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 6:41 AM
Unknown Object (File)
Wed, Apr 9, 11:57 AM
Unknown Object (File)
Mon, Apr 7, 3:55 PM
Unknown Object (File)
Mon, Apr 7, 1:01 AM
Unknown Object (File)
Sun, Apr 6, 11:44 PM
Unknown Object (File)
Sun, Apr 6, 1:48 PM
Unknown Object (File)
Feb 26 2025, 6:03 AM
Unknown Object (File)
Feb 26 2025, 6:03 AM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMMed98e4a6ebd2: [native][web] Rename P2P messages methods
Summary

Their names were inconsistent.

Test Plan

Flow, build native app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
2 lines
types/
4 lines
utils/
__mocks__/
4 lines
native/
cpp/
CommonCpp/
NativeModules/
4 lines
4 lines
_generated/
database/
4 lines
schema/
4 lines
web/
database/
4 lines

Diff 42696

View Options

lib/tunnelbroker/peer-to-peer-context.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines async keyserverAuthInfo => {
const responses: { +[string]: ClientLogInResponse } = const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'keyserver_auth', 'keyserver_auth',
requests, requests,
keyserverAuthCallSingleKeyserverEndpointOptions, keyserverAuthCallSingleKeyserverEndpointOptions,
); );
const userInfosArrays = [];
let threadInfos: RawThreadInfos = {}; let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = { const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery, calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [], rawEntryInfos: [],
}; };
const messagesResult: WritableGenericMessagesResult = { const messagesResult: WritableGenericMessagesResult = {
messageInfos: [], messageInfos: [],
truncationStatus: {}, truncationStatus: {},
Show All 21 Lines for (const keyserverID in responses) {
messagesResult.currentAsOf = { messagesResult.currentAsOf = {
...messagesResult.currentAsOf, ...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
updatesCurrentAsOf = { updatesCurrentAsOf = {
...updatesCurrentAsOf, ...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
} }
const userInfosArrays = [
responses[authoritativeKeyserverID()].userInfos,
responses[authoritativeKeyserverID()].cookieChange.userInfos,
tomekUnsubmitted
Not Done
Inline Actions

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
];
const userInfos = mergeUserInfos(...userInfosArrays); const userInfos = mergeUserInfos(...userInfosArrays);
return { return {
threadInfos, threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo, currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult, calendarResult,
messagesResult, messagesResult,
userInfos, userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines
View Options

lib/types/sqlite-types.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines async keyserverAuthInfo => {
const responses: { +[string]: ClientLogInResponse } = const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'keyserver_auth', 'keyserver_auth',
requests, requests,
keyserverAuthCallSingleKeyserverEndpointOptions, keyserverAuthCallSingleKeyserverEndpointOptions,
); );
const userInfosArrays = [];
let threadInfos: RawThreadInfos = {}; let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = { const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery, calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [], rawEntryInfos: [],
}; };
const messagesResult: WritableGenericMessagesResult = { const messagesResult: WritableGenericMessagesResult = {
messageInfos: [], messageInfos: [],
truncationStatus: {}, truncationStatus: {},
Show All 21 Lines for (const keyserverID in responses) {
messagesResult.currentAsOf = { messagesResult.currentAsOf = {
...messagesResult.currentAsOf, ...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
updatesCurrentAsOf = { updatesCurrentAsOf = {
...updatesCurrentAsOf, ...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
} }
const userInfosArrays = [
responses[authoritativeKeyserverID()].userInfos,
responses[authoritativeKeyserverID()].cookieChange.userInfos,
tomekUnsubmitted
Not Done
Inline Actions

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
];
const userInfos = mergeUserInfos(...userInfosArrays); const userInfos = mergeUserInfos(...userInfosArrays);
return { return {
threadInfos, threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo, currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult, calendarResult,
messagesResult, messagesResult,
userInfos, userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines
View Options

lib/utils/__mocks__/config.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines async keyserverAuthInfo => {
const responses: { +[string]: ClientLogInResponse } = const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'keyserver_auth', 'keyserver_auth',
requests, requests,
keyserverAuthCallSingleKeyserverEndpointOptions, keyserverAuthCallSingleKeyserverEndpointOptions,
); );
const userInfosArrays = [];
let threadInfos: RawThreadInfos = {}; let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = { const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery, calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [], rawEntryInfos: [],
}; };
const messagesResult: WritableGenericMessagesResult = { const messagesResult: WritableGenericMessagesResult = {
messageInfos: [], messageInfos: [],
truncationStatus: {}, truncationStatus: {},
Show All 21 Lines for (const keyserverID in responses) {
messagesResult.currentAsOf = { messagesResult.currentAsOf = {
...messagesResult.currentAsOf, ...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
updatesCurrentAsOf = { updatesCurrentAsOf = {
...updatesCurrentAsOf, ...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
} }
const userInfosArrays = [
responses[authoritativeKeyserverID()].userInfos,
responses[authoritativeKeyserverID()].cookieChange.userInfos,
tomekUnsubmitted
Not Done
Inline Actions

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
];
const userInfos = mergeUserInfos(...userInfosArrays); const userInfos = mergeUserInfos(...userInfosArrays);
return { return {
threadInfos, threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo, currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult, calendarResult,
messagesResult, messagesResult,
userInfos, userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines async keyserverAuthInfo => {
const responses: { +[string]: ClientLogInResponse } = const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint( await callKeyserverEndpoint(
'keyserver_auth', 'keyserver_auth',
requests, requests,
keyserverAuthCallSingleKeyserverEndpointOptions, keyserverAuthCallSingleKeyserverEndpointOptions,
); );
const userInfosArrays = [];
let threadInfos: RawThreadInfos = {}; let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = { const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery, calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [], rawEntryInfos: [],
}; };
const messagesResult: WritableGenericMessagesResult = { const messagesResult: WritableGenericMessagesResult = {
messageInfos: [], messageInfos: [],
truncationStatus: {}, truncationStatus: {},
Show All 21 Lines for (const keyserverID in responses) {
messagesResult.currentAsOf = { messagesResult.currentAsOf = {
...messagesResult.currentAsOf, ...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
updatesCurrentAsOf = { updatesCurrentAsOf = {
...updatesCurrentAsOf, ...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime, [keyserverID]: responses[keyserverID].serverTime,
}; };
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
} }
const userInfosArrays = [
responses[authoritativeKeyserverID()].userInfos,
responses[authoritativeKeyserverID()].cookieChange.userInfos,
tomekUnsubmitted
Not Done
Inline Actions

I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth.

tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
];
const userInfos = mergeUserInfos(...userInfosArrays); const userInfos = mergeUserInfos(...userInfosArrays);
return { return {
threadInfos, threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo, currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult, calendarResult,
messagesResult, messagesResult,
userInfos, userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/database/sqlite-api.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/database/sqlite-api.js

Loading...