Paths

Table of Contentst

Differential D12814

[terraform] webapp terraform config
ClosedPublic
Actions

Authored by will on Jul 19 2024, 8:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 10:44 PM

	Unknown Object (File)
	Fri, Nov 22, 3:21 PM

	Unknown Object (File)
	Sun, Nov 3, 5:34 AM

	Unknown Object (File)
	Fri, Nov 1, 10:45 AM

	Unknown Object (File)
	Oct 23 2024, 7:23 PM

	Unknown Object (File)
	Oct 23 2024, 7:23 PM

	Unknown Object (File)
	Oct 23 2024, 7:21 PM

	Unknown Object (File)
	Oct 18 2024, 2:35 PM

View All 51 Files

Subscribers

Details

Reviewers

Commits

rCOMMefb6e368088b: [terraform] webapp terraform config

Summary

The terraform configuration for running webapp nodes. Sets up a load balancer and a webapp ecs keyserver cluster service

Depends on D12813

Test Plan

Was able to access the web app through specified domain (comm.software)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 19 2024, 8:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 19 2024, 8:33 PM

will edited the summary of this revision. (Show Details)Jul 19 2024, 8:34 PM

will added a parent revision: D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.

will published this revision for review.Jul 19 2024, 8:49 PM

Harbormaster completed remote builds in B30531: Diff 42568.Jul 19 2024, 8:49 PM

will added a child revision: D12817: [terraform] upgrade self host image to 1.0.101.Jul 19 2024, 9:57 PM

ashoat accepted this revision.Jul 19 2024, 10:01 PM

This revision is now accepted and ready to land.Jul 19 2024, 10:01 PM

Don't love all the copy-paste here. Let's create a follow-up task to ask @bartek if there's a way to reduce it

services/terraform/self-host/webapp.tf
166–169	This pattern doesn't match the existing keyserver config, where this is specified in a separate `aws_lb.tf` file. Can you create a follow-up task to standardize the approach?

ashoat mentioned this in D12815: [terraform] landing terraform config.Jul 19 2024, 10:10 PM

Closed by commit rCOMMefb6e368088b: [terraform] webapp terraform config (authored by will). · Explain WhyJul 19 2024, 11:22 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMefb6e368088b: [terraform] webapp terraform config.

will added inline comments.Jul 22 2024, 11:10 AM

services/terraform/self-host/webapp.tf
166–169	Just created it here: https://linear.app/comm/issue/ENG-8887/standardize-load-balancer-setup-for-landing-and-webapp

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

169 lines

Diff 42568

services/terraform/self-host/webapp.tf

Loading...