Details

Reviewers

varun
bartek

Commits

rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web

Summary

Originally used a shared lb-sg but this is a bad idea given that the disabling ingress approach for the migration script would disable traffic for the webapp and landing page, not just
the keyserver.

Depends on D12874

Test Plan

terraform apply and was able to access landing page and webapp at custom domains

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 24 2024, 12:57 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2024, 12:57 PM

Harbormaster completed remote builds in B30652: Diff 42749.Jul 24 2024, 1:15 PM

will requested review of this revision.Jul 24 2024, 1:15 PM

will added a child revision: D12876: [terraform] Making user created vpc false by default.Jul 24 2024, 1:17 PM

will added a child revision: D12877: [terraform] Update terraform.tfvars.example and use json format.Jul 24 2024, 1:19 PM

bartek accepted this revision.Jul 25 2024, 6:51 AM

bartek added inline comments.

services/terraform/self-host/landing.tf
168 ↗	(On Diff #42749)	Can we be more specific here?
services/terraform/self-host/webapp.tf
168 ↗	(On Diff #42749)	Can we be more specific here?

This revision is now accepted and ready to land.Jul 25 2024, 6:51 AM

will added inline comments.Jul 25 2024, 7:08 AM

services/terraform/self-host/landing.tf
168 ↗	(On Diff #42749)	Thanks for catching that. Including in next rebase
services/terraform/self-host/webapp.tf
168 ↗	(On Diff #42749)	Same as above. Including in next rebase