Page MenuHomePhabricator

[terraform] Create module for webapp/landing and convert webapp to module
ClosedPublic

Authored by will on Jul 28 2024, 5:52 PM.
Tags
None
Referenced Files
F3331797: D12906.id43156.diff
Wed, Nov 20, 9:39 PM
F3331793: D12906.id43202.diff
Wed, Nov 20, 9:39 PM
F3331792: D12906.id43196.diff
Wed, Nov 20, 9:39 PM
Unknown Object (File)
Sun, Nov 10, 8:04 PM
Unknown Object (File)
Sun, Nov 10, 11:18 AM
Unknown Object (File)
Oct 19 2024, 8:24 AM
Unknown Object (File)
Oct 18 2024, 9:45 PM
Unknown Object (File)
Oct 18 2024, 9:45 PM
Subscribers

Details

Summary

This implements a module for the webapp and replaces the self-host webapp to use it

Depends on D12927

Test Plan

terraform apply. Webapp was accessible as prior to module implementation

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Jul 28 2024, 6:08 PM

Nice! The code structure looks neat!
In the future we can do a similar thing to our ECS services - modules can help avoid lots of duplication.

The only thing I have mixed feelings is the name node_service - I think of it as a Node.js service (in fact it is) 😅 Could it be sth like keyserver_node_service? IDK

P.S. Have you tried terraform state mv or just killed old resources and restarted? :D Just curious, I'd do the latter

This revision is now accepted and ready to land.Jul 28 2024, 11:55 PM

Nice! The code structure looks neat!
In the future we can do a similar thing to our ECS services - modules can help avoid lots of duplication.

The only thing I have mixed feelings is the name node_service - I think of it as a Node.js service (in fact it is) 😅 Could it be sth like keyserver_node_service? IDK

P.S. Have you tried terraform state mv or just killed old resources and restarted? :D Just curious, I'd do the latter

I just killed the old resources and restarted. In this specific scenario, I think we're fine as we plan on moving landing and webapp to comm services instead Ashoat's self hosted setup.

I think a rename makes sense here, it's just that I wanted to separate the concept of a webapp and landing node from a keyserver node although they technically all run off the keyserver. I'll change it to keyserver_node_service for now