Page MenuHomePhabricator
Differential D12912

[lib] handle `BadDeviceToken` message
ClosedPublic
Actions

Authored by kamil on Jul 29 2024, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 1:46 AM
Unknown Object (File)
Sat, Oct 19, 8:23 AM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Tue, Oct 15, 6:24 PM
Unknown Object (File)
Sun, Oct 6, 8:28 PM
Unknown Object (File)
Sep 19 2024, 5:57 PM
Unknown Object (File)
Sep 19 2024, 5:53 PM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
tomek
Commits
rCOMM10b64a112df7: [lib] handle `BadDeviceToken` message
Summary

ENG-8498.

Updating state after receiving message from TB.

Depends on D12911

Test Plan

Repeat test plan from D12911

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2024, 2:56 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 2:56 AM
Harbormaster completed remote builds in B30736: Diff 42864.Jul 29 2024, 3:18 AM
kamil added a child revision: D12915: [web][desktop] refresh device token after receiving message from Tunnelbroker.Jul 29 2024, 4:07 AM
kamil added a child revision: D12916: [native] refresh device token after receiving message from Tunnelbroker.
kamil edited the summary of this revision. (Show Details)Jul 29 2024, 6:38 AM
kamil edited the test plan for this revision. (Show Details)
kamil published this revision for review.Jul 29 2024, 6:42 AM
kamil added a reviewer: tomek.
kamil added inline comments.
lib/reducers/tunnelbroker-device-token-reducer.js
37–38 ↗(On Diff #42864)

We set tunnelbrokerToken to null because when receiving BAD_DEVICE_TOKEN Tunnelbroker is no longer trying to use that device token - so we can assume Tunnelbroker doesn't have any token.
Additionally, this makes TunnelbrokerDeviceTokenHandler to upload token even if the same token was retrieved by native API (I think there is a really low chance for this, but still worth handling).

kamil mentioned this in D12910: [Tunnelbroker][lib] add `BadDeviceToken` message type.Jul 29 2024, 8:26 AM
tomek accepted this revision.Jul 30 2024, 2:22 AM
This revision is now accepted and ready to land.Jul 30 2024, 2:22 AM
Closed by commit rCOMM10b64a112df7: [lib] handle `BadDeviceToken` message (authored by kamil). · Explain WhyAug 1 2024, 1:28 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM10b64a112df7: [lib] handle `BadDeviceToken` message.
ashoat added inline comments.Aug 1 2024, 1:31 PM
lib/actions/tunnelbroker-actions.js
9

We have a convention that this name should end in ActionType

kamil added a child revision: D12968: [lib] rename `invalidateTunnelbrokerDeviceToken` -> `invalidateTunnelbrokerDeviceTokenActionType`.Aug 5 2024, 3:53 AM
kamil added inline comments.Aug 5 2024, 3:57 AM
lib/actions/tunnelbroker-actions.js
9

thanks for catching: D12968

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
reducers/
15 lines
tunnelbroker/
13 lines
types/
8 lines

Diff 43010

View Options

lib/actions/tunnelbroker-actions.js

Loading...
View Options

lib/reducers/tunnelbroker-device-token-reducer.js

Loading...
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

lib/types/redux-types.js

Loading...