[protos][identity] Add reserved usernames to UserIdentitiesResponse
ClosedPublic
Actions

Authored by bartek on Jul 29 2024, 11:32 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMMca98cfd13157: [protos][identity] Add reserved usernames to UserIdentitiesResponse

Summary

First part of ENG-8771 - added a new response field as proposed in this comment.
This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map.

Test Plan

Flow, cargo build. Logic is added in the next diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 29 2024, 11:32 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJul 29 2024, 11:32 AM

bartek added a child revision: D12924: [identity] Query reserved usernames in FindUserIdentities RPC.Jul 29 2024, 11:38 AM

Harbormaster completed remote builds in B30767: Diff 42910.Jul 29 2024, 11:49 AM

bartek published this revision for review.Jul 29 2024, 12:01 PM

bartek added inline comments.

services/identity/src/grpc_services/authenticated.rs
882 ↗	(On Diff #42910)	Actual implementation in D12924
web/protobufs/identity-auth-structs.cjs.flow
621 ↗	(On Diff #42910)	I noticed that everywhere else we use `ProtoMap` for types being defined as `map<string, Whatever>` in protos

varun accepted this revision.Jul 29 2024, 10:18 PM

Haven't reviewed the Rust but the changes seem minimal / safe

shared/protos/identity_auth.proto
323 ↗	(On Diff #42910)	How about `reserved_user_identifiers`? I think it's weird to use the same noun ("identities") here when the type is different from `identities` above
web/protobufs/identity-auth-structs.cjs.flow
621 ↗	(On Diff #42910)	Good find