Page MenuHomePhabricator

[lib][native][web] Extend findUserIdentities response type
ClosedPublic

Authored by bartek on Jul 29 2024, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Sun, Nov 3, 5:50 PM
Unknown Object (File)
Sat, Oct 19, 8:23 AM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Fri, Oct 18, 9:46 PM
Unknown Object (File)
Fri, Oct 18, 9:20 AM
Unknown Object (File)
Fri, Oct 18, 9:20 AM
Subscribers

Details

Summary

Updated Flow types and validators to include extended response of the FindUserIdentities RPC.
Kept previous logic, I didn't made any use of the new extended response.

Depends on D12925

Test Plan

Flow, repeated test plan from D12925 (generally played with modified functions). Made sure they work as before

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jul 29 2024, 12:04 PM

Makes sense. I think we'll need to update the two handler components here to look at the newly-returned reservedUserIdentities property, but my impression is that this will be handled by @inka in a later diff

This revision is now accepted and ready to land.Jul 30 2024, 10:57 PM

Rename to reservedUserIdentifiers

I think we'll need to update the two handler components here to look at the newly-returned reservedUserIdentities property, but my impression is that this will be handled by @inka in a later diff

Yeah, I think that's the plan

Yeah, I think that's the plan

Yes!