[Tunnelbroker] handle `SetDeviceTokenWithPlatform` message
ClosedPublic
Actions

Authored by kamil on Jul 30 2024, 4:09 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMMd1e671ead32f: [Tunnelbroker] handle `SetDeviceTokenWithPlatform` message

Summary

ENG-8903.

Updated client to send platform details.

Depends on D12938

Test Plan

Logout/Login on device and check if column is populated in DDB.

Diff Detail

Repository

rCOMM Comm

Branch

final-stack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 30 2024, 4:09 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 4:09 AM

kamil added a child revision: D12940: [Tunnelbroker] validate device platform before sending notif.Jul 30 2024, 4:12 AM

kamil published this revision for review.Jul 30 2024, 5:37 AM

kamil added inline comments.

lib/handlers/tunnelbroker-device-token-handler.react.js
24 ↗	(On Diff #42952)	this line is here because otherwise Flow complains

Harbormaster completed remote builds in B30807: Diff 42952.Jul 30 2024, 6:04 AM

In what situations are we going to keep using the old SetDeviceTokenWithoutPlatform?

This revision is now accepted and ready to land.Jul 30 2024, 7:57 AM

I am going to remove client code from this diff before landing (we first need to deploy TB) and then I'll create a second diff with only client changes.

In D12939#366010, @bartek wrote:

In what situations are we going to keep using the old SetDeviceTokenWithoutPlatform?

This is currently done by existing clients who are connected to Tunnelbroker (having CSAT) and could attempt to refresh device token.

remove client code

kamil retitled this revision from [Tunnelbroker][lib] start using `SetDeviceTokenWithPlatform` to [Tunnelbroker] handle `SetDeviceTokenWithPlatform` message.Jul 31 2024, 4:13 AM

Harbormaster completed remote builds in B30833: Diff 42991.Jul 31 2024, 4:28 AM

Closed by commit rCOMMd1e671ead32f: [Tunnelbroker] handle `SetDeviceTokenWithPlatform` message (authored by kamil). · Explain WhyJul 31 2024, 7:14 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMd1e671ead32f: [Tunnelbroker] handle `SetDeviceTokenWithPlatform` message.

kamil added a child revision: D12955: [lib] start using `SetDeviceTokenWithPlatform`.Aug 1 2024, 1:31 AM