Page MenuHomePhabricator

[terraform] Deploy Tunnelbroker 0.14 to staging and prod
ClosedPublic

Authored by kamil on Jul 31 2024, 7:19 AM.
Tags
None
Referenced Files
F3571198: D12953.id43005.diff
Sat, Dec 28, 8:25 AM
F3571197: D12953.id43004.diff
Sat, Dec 28, 8:25 AM
F3571196: D12953.id.diff
Sat, Dec 28, 8:25 AM
F3571195: D12953.diff
Sat, Dec 28, 8:25 AM
Unknown Object (File)
Wed, Dec 25, 9:26 PM
Unknown Object (File)
Wed, Dec 11, 5:54 PM
Unknown Object (File)
Nov 9 2024, 11:36 PM
Unknown Object (File)
Nov 6 2024, 10:49 PM
Subscribers

Details

Summary

Deploying newest Tunnelbroker image.

For staging this is invalid device token work.
For prod this is invalid device work and APNs, FCM and Web Push notifs.

Test Plan

Run terraform plan -target aws_ecs_service.tunnelbroker on staging and prod.

Also, tested logic end-to-end: ENG-8508.

Diff Detail

Repository
rCOMM Comm
Branch
deploy
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 31 2024, 7:19 AM
This revision is now accepted and ready to land.Jul 31 2024, 7:30 AM

Didn't we conclude in a recent retro that we always want to deploy updates images to staging first, before production? Did we make an exception here because Tunnelbroker is barely live in production?

Didn't we conclude in a recent retro that we always want to deploy updates images to staging first, before production? Did we make an exception here because Tunnelbroker is barely live in production?

Most of the logic I deployed on prod (notifs work) was on the staging for some time and was tested by my and @marcin,
For the invalid device token work, I deployed this on staging and spent most of the day testing this before releasing, additionally, this is notifs- related error handling code, it's an additional feature and is not affecting existing logic which is live, and for some time it won't be executed so decided to deploy both.

But overall, I agree with you - I should've bump staging to 0.14 and prod to 0.12 (not 0.14) to keep our deploying process consent, thanks for pointing that out.