Page MenuHomePhabricator
Differential D12961

[lib] Delete auxUserStore users on authoritative keyserver request
ClosedPublic
Actions

Authored by bartek on Aug 4 2024, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:26 AM
Unknown Object (File)
Fri, Nov 22, 1:13 AM
Unknown Object (File)
Thu, Nov 14, 7:01 PM
Unknown Object (File)
Sat, Nov 9, 4:39 PM
Unknown Object (File)
Thu, Nov 7, 1:55 AM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Sat, Nov 2, 4:20 AM
Unknown Object (File)
Sat, Nov 2, 4:20 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
inka
kamil
tomek
Commits
rCOMMdf0ead45ef88: [lib] Delete auxUserStore users on authoritative keyserver request
Summary

When a user deletes account, authoritative keyserver sends updates to known peers, which in user-reducer are processed and the user is deleted from their userStores.
We want the same for auxUserStore, when a peer deletes their account.

When relying on authoritative keyserver, we can simply copy the action to auxUserStore.
Scenario with relyingOnAuthoritativeKeyserve = false is handled in the next diff

Depends on D12945

Test Plan
  • Register two users and make sure they know about each other (have entries in user stores)
  • Delete account for one user
  • Make sure it gets removed from the other user's userStore and auxUserStore

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 4 2024, 11:43 PM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 4 2024, 11:43 PM
bartek added a child revision: D12962: [lib] Add action type to remove peer user.Aug 4 2024, 11:45 PM
Harbormaster failed remote builds in B30879: Diff 43059!Aug 5 2024, 12:05 AM
bartek published this revision for review.Aug 5 2024, 2:27 AM
kamil accepted this revision.Aug 5 2024, 4:49 AM

Wondering how we should me sure we keep those two in sync to avoid cases like here.

This revision is now accepted and ready to land.Aug 5 2024, 4:49 AM
inka requested changes to this revision.Aug 5 2024, 5:15 AM
inka added inline comments.
lib/reducers/aux-user-reducer.js
187 ↗(On Diff #43059)

Shouldn't we be returning removeUsersOps?

This revision now requires changes to proceed.Aug 5 2024, 5:15 AM
bartek updated this revision to Diff 43096.Aug 5 2024, 5:30 AM

Return missing ops

inka accepted this revision.Aug 5 2024, 5:34 AM
This revision is now accepted and ready to land.Aug 5 2024, 5:34 AM
This revision was landed with ongoing or failed builds.Aug 5 2024, 5:54 AM
Closed by commit rCOMMdf0ead45ef88: [lib] Delete auxUserStore users on authoritative keyserver request (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMdf0ead45ef88: [lib] Delete auxUserStore users on authoritative keyserver request.
Harbormaster failed remote builds in B30916: Diff 43096!Aug 5 2024, 6:45 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
46 lines

Diff 43096

View Options

lib/reducers/aux-user-reducer.js

Loading...