[lib] Increase join thread timeout
ClosedPublic
Actions

Authored by tomek on Aug 6 2024, 6:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 6:58 AM

	Unknown Object (File)
	Sat, Nov 2, 6:57 AM

	Unknown Object (File)
	Sat, Nov 2, 6:57 AM

	Unknown Object (File)
	Sat, Nov 2, 6:40 AM

	Unknown Object (File)
	Sat, Oct 19, 8:24 AM

	Unknown Object (File)
	Fri, Oct 18, 9:45 PM

	Unknown Object (File)
	Fri, Oct 18, 9:45 PM

	Unknown Object (File)
	Oct 6 2024, 8:43 PM

View All 39 Files

Subscribers

ashoat

Details

Reviewers

kamil
inka

Commits

rCOMM1ff5615ee82f: [lib] Increase join thread timeout

Summary

Make it consistent with other request that can take longer.

https://linear.app/comm/issue/ENG-8958/invite-invalid-when-trying-to-join-the-comm-community

Test Plan

Check if joining a community through an invite link works on web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 6 2024, 6:21 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 6 2024, 6:21 AM

Harbormaster completed remote builds in B30958: Diff 43181.Aug 6 2024, 6:42 AM

tomek requested review of this revision.Aug 6 2024, 6:42 AM

tomek added a child revision: D13000: [lib] Make sure we send only one join thread request at a time.Aug 6 2024, 6:49 AM

inka accepted this revision.Aug 6 2024, 7:58 AM

This revision is now accepted and ready to land.Aug 6 2024, 7:58 AM

Closed by commit rCOMM1ff5615ee82f: [lib] Increase join thread timeout (authored by tomek). · Explain WhyAug 6 2024, 8:12 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1ff5615ee82f: [lib] Increase join thread timeout.

Revision Contents
Changeset List

Path

Size

lib/

actions/

thread-actions.js

9 lines

Diff 43185

View Options

lib/actions/thread-actions.js

[lib] Increase join thread timeoutClosedPublicActions