[lib] Properly handle server call timeout when accepting an invite link
ClosedPublic
Actions

Authored by tomek on Aug 6 2024, 7:01 AM.

Details

Reviewers

kamil
inka

Commits

rCOMM5d9dc180d029: [lib] Properly handle server call timeout when accepting an invite link

Summary

We should distinguish timeout errors from other types.

https://linear.app/comm/issue/ENG-8958/invite-invalid-when-trying-to-join-the-comm-community

Depends on D13000

Test Plan

Modify thread join timeout to 10ms, accept a link and verify that the timeout message is being shown. Also verified that accepting the link still works with the original timeout.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 6 2024, 7:01 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 6 2024, 7:01 AM

Harbormaster completed remote builds in B30960: Diff 43184.Aug 6 2024, 7:17 AM

tomek requested review of this revision.Aug 6 2024, 7:17 AM

tomek edited the summary of this revision. (Show Details)Aug 6 2024, 7:57 AM

tomek added a parent revision: D13000: [lib] Make sure we send only one join thread request at a time.

inka accepted this revision.Aug 6 2024, 8:10 AM

This revision is now accepted and ready to land.Aug 6 2024, 8:10 AM

Closed by commit rCOMM5d9dc180d029: [lib] Properly handle server call timeout when accepting an invite link (authored by tomek). · Explain WhyAug 6 2024, 8:12 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5d9dc180d029: [lib] Properly handle server call timeout when accepting an invite link.

Revision Contents
Changeset List

Path

Size

lib/

shared/

community-utils.js

21 lines

Diff 43187

View Options

lib/shared/community-utils.js

[lib] Properly handle server call timeout when accepting an invite linkClosedPublicActions