This differential fixes https://linear.app/comm/issue/ENG-8987/web-notifs-became-broken-on-prod. There is no need to throw if there is no notiufs account in IndexedDB when decrypting keyserver notif since it is not necessary to potentially create session. Peer-based notifs have other checks in the code that will throw if there is no notifs account in indexeddb.
Details
Details
- Before this diff remove notificationAccount entry in IndexedDB. Send notif. Expect broken one.
- Apply this diff and remove notificationAccount entry in IndexedDB. Send notif. Expect correct one.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8987
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/push-notif/notif-crypto-utils.js | ||
|---|---|---|
| 210–215 | This check was never necessary. It was an artifact that I left before modifying the type of getNotifsAccountWithOlmData to return optional notif account. | |