Looks like these dependencies are for fsevents and macos-alias, which are still using the old nan:
macos-alias is used by @electron-forge/maker-dmg, which is used in our electron-forge config
Version 1 of fsevents requires nan, but version 2 doesn't. We have dependencies on version 1 due to an old version of Jest that is required by hazel-server (we have the latest version of hazel-server)
Don't think either of those will be affected by the Windows issues we've seen, so we can leave it. But in the future, one thing we could do here would've been to update all of these to 2.20.0, since it looks like it just fixes bugs and shouldn't have negative effects
Details
Details
- Reviewers
ashoat - Commits
- rCOMM261ef8666355: remove nan@2.17.0 from yarn.lock
successfully built app on windows
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The resolution isn't necessary here. To achieve this I would have manually modified yarn.lock and just committed that. You could potentially introduce the change with the resolution and then delete it later if you're not comfortable modifying yarn.lock directly. But we should avoid committing the resolution... it locks us to 2.20.0, but there's no reason to do that
| package.json | ||
|---|---|---|
| 59 ↗ | (On Diff #43225) | Remove this line |