Page MenuHomePhabricator
Differential D13020

[tunnelbroker] invalidate bad wns device tokens
ClosedPublic
Actions

Authored by varun on Aug 7 2024, 3:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 10:04 PM
Unknown Object (File)
Fri, Apr 4, 9:50 PM
Unknown Object (File)
Fri, Apr 4, 6:58 PM
Unknown Object (File)
Fri, Apr 4, 2:15 PM
Unknown Object (File)
Mar 21 2025, 5:20 PM
Unknown Object (File)
Mar 12 2025, 11:35 AM
Unknown Object (File)
Mar 7 2025, 8:51 AM
Unknown Object (File)
Mar 6 2025, 4:45 AM
View All 83 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMM3f814c0b29f7: [tunnelbroker] invalidate bad wns device tokens
Summary

based on keyserver error codes

see wns response codes here

Test Plan

Manually malform device token for windows device in DDB (url), try sending notif to this device and verify that flag was flipped

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
wns/
4 lines
websockets/
20 lines

Diff 43269

View Options

services/tunnelbroker/src/notifs/wns/mod.rs

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

services/tunnelbroker/src/websockets/session.rs

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines