Page MenuHomePhabricator

[native] introduce resetting Outbound P2P Messages to `CommCoreModule`
ClosedPublic

Authored by kamil on Aug 8 2024, 4:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 11:05 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Sun, Nov 3, 5:45 AM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Sep 27 2024, 6:04 PM
Unknown Object (File)
Sep 25 2024, 4:12 PM
Subscribers

Details

Summary

The code on native to interface with search API using JSI.

Depends on D13029

Test Plan

Tested in D13032

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 8 2024, 5:30 AM
kamil edited the test plan for this revision. (Show Details)
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2885–2892 ↗(On Diff #43258)

We're doing something similar in a lot of places. Might be a good idea to introduce some utils for std collections <-> jsi collections conversions. (But we shouldn't prioritize it soon)

This revision is now accepted and ready to land.Aug 12 2024, 1:17 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2885–2892 ↗(On Diff #43258)