Page MenuHomePhabricator

[lib] resend messages after session creation request
ClosedPublic

Authored by kamil on Aug 13 2024, 4:49 AM.
Tags
None
Referenced Files
F2715468: D13056.id43548.diff
Mon, Sep 16, 3:18 AM
F2715467: D13056.id43332.diff
Mon, Sep 16, 3:18 AM
Unknown Object (File)
Sun, Sep 15, 9:07 AM
Unknown Object (File)
Sun, Sep 15, 9:06 AM
Unknown Object (File)
Tue, Sep 10, 1:35 PM
Unknown Object (File)
Sat, Sep 7, 8:09 PM
Unknown Object (File)
Thu, Sep 5, 12:43 PM
Unknown Object (File)
Thu, Sep 5, 11:02 AM
Subscribers

Details

Summary

ENG-6982.

The code here is executed in two cases:

  1. First session request - this call is a no-op because we haven't sent any Outbound messages yet.
  2. Session request with higher session - this means that the device that sent the request has a malformed session and we need to re-encrypt and resend all not confirmed messages.

Depends on D13032

Test Plan
  1. Create a session between devices A and B
  2. On B comment out sending confirmation.
  3. Send some messages from A to B
  4. From B to A send session request with higher session counter.
  5. Test that all messages are sent again and decrypted successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 13 2024, 4:49 AM
kamil edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mon, Aug 19, 5:55 AM