Page MenuHomePhabricator
Differential D13028

[SQLite] implement resetting Outbound P2P messages
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2025, 11:12 PM
Unknown Object (File)
Feb 22 2025, 11:11 PM
Unknown Object (File)
Feb 22 2025, 11:09 PM
Unknown Object (File)
Feb 6 2025, 2:06 AM
Unknown Object (File)
Jan 25 2025, 6:01 PM
Unknown Object (File)
Jan 22 2025, 3:40 PM
Unknown Object (File)
Jan 22 2025, 3:39 PM
Unknown Object (File)
Dec 22 2024, 3:51 PM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
tomek
Commits
rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages
Summary

ENG-6982.

It is possible to do it as one query but will be more complicated and less readable, I can update if reviewers think it worth it.

Each query is described in code comments.

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Aug 8 2024, 4:23 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 4:23 AM
kamil added a child revision: D13029: [web] introduce resetting Outbound P2P Messages to shared worker.Aug 8 2024, 4:25 AM
Harbormaster failed remote builds in B31007: Diff 43256!Aug 8 2024, 4:46 AM
kamil published this revision for review.Aug 8 2024, 5:06 AM
tomek accepted this revision.Aug 12 2024, 1:11 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611 ↗(On Diff #43256)

What happens if one of them succeeds and one fails?

This revision is now accepted and ready to land.Aug 12 2024, 1:11 AM
kamil added inline comments.Aug 13 2024, 3:26 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611 ↗(On Diff #43256)

good call, I am going to wrap this in transaction in the following diffs

Harbormaster completed remote builds in B31007: Diff 43256.Aug 13 2024, 3:43 AM
Closed by commit rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages (authored by kamil). · Explain WhyAug 13 2024, 4:10 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdacfe284e5b0: [SQLite] implement resetting Outbound P2P messages.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
78 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
82 lines
types/
1 line

Diff 43328

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Show First 20 Lines • Show All 1,213 Lines • ▼ Show 20 Lines const newState = {
...rest, ...rest,
alertStore: { alertStore: {
alertInfos: defaultAlertInfos, alertInfos: defaultAlertInfos,
}, },
}; };
return newState; return newState;
}, },
[70]: (state: any) => {
const clientDBMessageInfos = commCoreModule.getAllMessagesSync();
const unsupportedMessageIDsToRemove = clientDBMessageInfos
.filter(
message =>
parseInt(message.type) === messageTypes.UNSUPPORTED &&
parseInt(message.future_type) === messageTypes.UPDATE_RELATIONSHIP,
)
.map(message => message.id);
const messageStoreOperations: $ReadOnlyArray<ClientDBMessageStoreOperation> =
[
{
type: 'remove',
payload: { ids: unsupportedMessageIDsToRemove },
},
];
try {
commCoreModule.processMessageStoreOperationsSync(messageStoreOperations);
} catch (exception) {
console.log(exception);
if (isTaskCancelledError(exception)) {
return state;
}
return { ...state, cookie: null };
}
return state;
},
}; };
type PersistedReportStore = $Diff< type PersistedReportStore = $Diff<
ReportStore, ReportStore,
{ +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> }, { +queuedReports: $ReadOnlyArray<ClientReportCreationRequest> },
>; >;
const reportStoreTransform: Transform = createTransform( const reportStoreTransform: Transform = createTransform(
(state: ReportStore): PersistedReportStore => { (state: ReportStore): PersistedReportStore => {
return { enabledReports: state.enabledReports }; return { enabledReports: state.enabledReports };
}, },
(state: PersistedReportStore): ReportStore => { (state: PersistedReportStore): ReportStore => {
return { ...state, queuedReports: [] }; return { ...state, queuedReports: [] };
}, },
{ whitelist: ['reportStore'] }, { whitelist: ['reportStore'] },
); );
const persistConfig = { const persistConfig = {
key: 'root', key: 'root',
storage: AsyncStorage, storage: AsyncStorage,
blacklist: persistBlacklist, blacklist: persistBlacklist,
debug: __DEV__, debug: __DEV__,
version: 69, version: 70,
transforms: [ transforms: [
messageStoreMessagesBlocklistTransform, messageStoreMessagesBlocklistTransform,
reportStoreTransform, reportStoreTransform,
keyserverStoreTransform, keyserverStoreTransform,
], ],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 16 Lines
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...