Paths

Table of Contentst

Differential D13043

[lib] Fail signing device list if called by secondary device
ClosedPublic
Actions

Authored by bartek on Aug 11 2024, 3:16 AM.

Tags

None

Referenced Files

	F3758355: D13043.diff
	Fri, Jan 10, 8:40 AM

	Unknown Object (File)
	Sat, Dec 28, 7:25 AM

	Unknown Object (File)
	Sat, Dec 28, 7:25 AM

	Unknown Object (File)
	Sat, Dec 28, 7:25 AM

	Unknown Object (File)
	Sat, Dec 28, 7:25 AM

	Unknown Object (File)
	Dec 10 2024, 5:11 AM

	Unknown Object (File)
	Dec 9 2024, 3:38 PM

	Unknown Object (File)
	Dec 9 2024, 1:35 PM

View All 48 Files

Subscribers

Details

Reviewers

kamil
varun

Commits

rCOMMd628ec7a8a59: [lib] Fail signing device list if called by secondary device

Summary

Made signDeviceList() throw when called from non-primary devices.

Test Plan

Unit tests - needed to update them because otherwise mocked primaryContentSigningKey was different than primary device ID from device lists and some tests failed on the throw added in this diff - this proofs that it actually works.
Tested manually

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 11 2024, 3:16 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 11 2024, 3:16 AM

Harbormaster failed remote builds in B31034: Diff 43295!Aug 11 2024, 3:34 AM

bartek published this revision for review.Aug 12 2024, 12:08 AM

ashoat added inline comments.Aug 12 2024, 6:50 AM

lib/shared/device-list-utils.js
145	Will this error get caught somewhere? I'm worried about the app crashing here

kamil accepted this revision.Aug 12 2024, 8:15 AM

kamil added inline comments.

lib/shared/device-list-utils.js
145	While adding the device (scanning QR) it is caught here to show the alert. If we sign the device list as a result of P2P messages from other own devices, this error is also caught here.

This revision is now accepted and ready to land.Aug 12 2024, 8:15 AM

This revision was landed with ongoing or failed builds.Aug 19 2024, 4:42 AM

Closed by commit rCOMMd628ec7a8a59: [lib] Fail signing device list if called by secondary device (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd628ec7a8a59: [lib] Fail signing device list if called by secondary device.

Revision Contents
Changeset List

Path

Size

lib/

shared/

device-list-utils.js

8 lines

device-list-utils.test.js

4 lines

Diff 43295

lib/shared/device-list-utils.js

Loading...

lib/shared/device-list-utils.test.js

Loading...