[lib] Split change thread settings spec
ClosedPublic
Actions

Authored by tomek on Aug 12 2024, 7:27 AM.

Details

Reviewers

kamil
inka

Commits

rCOMMf8120854b4f3: [lib] Split change thread settings spec

Summary

Avoid sending unnecessary data and simplify the spec logic.

Depends on D13052

Test Plan

Checked two scenarios:

Viewer creates a thread and adds a new user to it using change_thread_settings operation
Viewer is added to a thread using change_thread_settings_and_add_viewer operation

In both cases the thread appeared in the store with correct membership array.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tomek requested review of this revision.Aug 12 2024, 8:55 AM

lib/shared/dm-ops/add-members-spec.js
27–28 ↗	(On Diff #43313)	What's the point of making the field read-only if the value isn't?

inka added inline comments.

lib/shared/dm-ops/change-thread-settings-and-add-viewer-spec.js
14 ↗	(On Diff #43313)	Can we call it `createAddViewerOperation`? or `createAddViewerToThreadOperation`
33 ↗	(On Diff #43313)	Can we merge this with the function above?

This revision is now accepted and ready to land.Aug 19 2024, 5:56 AM

Rename, fix the types

lib/shared/dm-ops/add-members-spec.js
27–28 ↗	(On Diff #43313)	Right, this isn't too useful.
lib/shared/dm-ops/change-thread-settings-and-add-viewer-spec.js
14 ↗	(On Diff #43313)	Renamed to `createAddViewerAndMembersOperation` because there might be more users that get added.
33 ↗	(On Diff #43313)	We can't because `createAddMembersOperation` is used in `canBeProcessed`.