Implement new optional olm-api methods on web to support notifs session creation on client demand
AcceptedPublic
Actions

Authored by marcin on Aug 15 2024, 10:25 AM.

Details

Reviewers

tomek
kamil
ashoat

Summary

This differentila introduces new olm-api methods. One to check if we have notifs session with the keyserver and the other two to create and persist later new notifs olm session with the keyserver.

Test Plan

Tested in next diff

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-9025

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 15 2024, 10:25 AM

marcin added a parent revision: D13090: Implement new endpoint on the keyserver to create notifs olm session on client demand.Aug 15 2024, 10:26 AM

marcin added a child revision: D13092: Implement keyserver notifs olm session recreation logic in keyserver-connection-handler.Aug 15 2024, 10:36 AM

Harbormaster completed remote builds in B31114: Diff 43410.Aug 15 2024, 10:42 AM

marcin requested review of this revision.Aug 15 2024, 10:42 AM

kamil accepted this revision.Mon, Aug 19, 5:47 AM

kamil added inline comments.

web/push-notif/notif-crypto-utils.js
1105	I would change this log, or are you sure this method is called only as a result of receiving notif?
web/shared-worker/worker/worker-crypto.js
931	shouldn't this be `true`?
937	why we're using `mixed`, not `PersistNotifsAccountWithOlmDataInput`?
939–942	why this is needed?