Page MenuHomePhabricator
Differential D13092

Implement keyserver notifs olm session recreation logic in keyserver-connection-handler
AcceptedPublic
Actions

Authored by marcin on Aug 15 2024, 10:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 2:06 PM
Unknown Object (File)
Wed, Nov 20, 2:06 PM
Unknown Object (File)
Thu, Nov 7, 8:29 PM
Unknown Object (File)
Oct 22 2024, 1:16 PM
Unknown Object (File)
Oct 22 2024, 9:15 AM
Unknown Object (File)
Oct 22 2024, 8:32 AM
Unknown Object (File)
Oct 16 2024, 9:58 PM
Unknown Object (File)
Sep 22 2024, 5:46 AM
View All 31 Files
Subscribers
None

Details

Reviewers
tomek
kamil
ashoat
Summary

This differential implements notifs olm session recreation logic in keyserver-connection-handler.

Test Plan
  1. Log in to web app.
  2. Open IndexedDB in Developer tools.
  3. Remove keyserver notifs session or keyserver notifs session encryption key or both.
  4. Refresh the web app.
  5. Ensure that keyserver notifs session or keyserver notifs session encryption key or both are back in IndexedDB.
  6. Ensure that web notifs work.

Test both Safari and Chrome

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9025
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Aug 15 2024, 10:36 AM
marcin added a parent revision: D13091: Implement new optional olm-api methods on web to support notifs session creation on client demand.Aug 15 2024, 10:36 AM
Harbormaster completed remote builds in B31115: Diff 43411.Aug 15 2024, 11:03 AM
marcin requested review of this revision.Aug 15 2024, 11:03 AM
kamil accepted this revision.Aug 19 2024, 6:53 AM
kamil added inline comments.
lib/keyserver-conn/keyserver-connection-handler.js
308–408

I would move this to a separate hook to clean-up KeyserverConnectionHandler.

This revision is now accepted and ready to land.Aug 19 2024, 6:53 AM

Revision Contents
Changeset List

PathSize
lib/
keyserver-conn/
109 lines

Diff 43411

View Options

lib/keyserver-conn/keyserver-connection-handler.js

Loading...