[lib] Allow admins to react and edit messages in sidebars
ClosedPublic
Actions

Authored by ashoat on Aug 19 2024, 8:07 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMd7722d01d6c5: [lib] Allow admins to react and edit messages in sidebars

Summary

This resolves ENG-9053.

In D13061, I accidentally limited these permissions to top-level (non-sidebar) descendants, instead of granting them for all descendants.

We only need to use TOP_LEVEL_DESCENDANT in cases where we want to restrict the permission for sidebars… for instance, we don't want sidebars to have children, so we use TOP_LEVEL_DESCENDANT for sidebar and subchannel creation permissions.

Test Plan

I set up a repro of the issue in my local environment
I applied this diff to fix the issue
I reset db_version to 67 to trigger migration 68 again
After migration 68 ran again, I confirmed that the issue was gone

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/permissions

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 19 2024, 8:07 AM

Harbormaster completed remote builds in B31145: Diff 43459.Aug 19 2024, 8:23 AM

ashoat requested review of this revision.Aug 19 2024, 8:23 AM

ashoat added a child revision: D13113: [lib] Propagate MEMBER permissions to all chats in a community.Aug 19 2024, 8:24 AM

tomek accepted this revision.Aug 20 2024, 1:31 AM

tomek added inline comments.

lib/permissions/thread-permissions.js
256–257	Shouldn't this also be `DESCENDANT`?

This revision is now accepted and ready to land.Aug 20 2024, 1:31 AM

ashoat added inline comments.Aug 20 2024, 7:14 AM

lib/permissions/thread-permissions.js
256–257	No, this is intentional. In order to be a member of a sidebar, we require that a user is a member of the parent thread. This is because we don't have a good way to render the sidebar in the inbox UI without the parent thread also being there. The permission to join a sidebar is granted by the `openChildJoinThread` permission assigned in `getRolePermissionBlobs`.