Page MenuHomePhabricator
Differential D13113

[lib] Propagate MEMBER permissions to all chats in a community
ClosedPublic
Actions

Authored by ashoat on Aug 19 2024, 8:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 6:10 AM
Unknown Object (File)
Feb 6 2025, 9:02 AM
Unknown Object (File)
Jan 27 2025, 7:41 AM
Unknown Object (File)
Jan 27 2025, 7:40 AM
Unknown Object (File)
Jan 27 2025, 7:40 AM
Unknown Object (File)
Jan 26 2025, 3:45 AM
Unknown Object (File)
Jan 25 2025, 2:18 AM
Unknown Object (File)
Jan 15 2025, 1:41 PM
View All 67 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMMf672592b5de0: [lib] Propagate MEMBER permissions to all chats in a community
Summary

This addresses ENG-9054.

The issue is that in D13014, I return false from includeThreadPermissionForThreadType even if a propagation prefix is set.

We want role permissions to apply to all chats in a community, even if there is a "broken link" where you are a member of a grandchild but not a member of its parent.

Depends on D13112

Test Plan
  1. I set up a repro of the issue in my local environment
  2. I applied this diff to fix the issue
  3. I reset db_version to 67 to trigger migration 68 again
  4. After migration 68 ran again, I confirmed that the issue was gone

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
permissions/
1 line

Diff 43512

View Options

lib/permissions/prefixes.js

Show All 14 Lines
], ],
"parser": "@babel/eslint-parser", "parser": "@babel/eslint-parser",
"plugins": [ "plugins": [
"react", "react",
"react-hooks", "react-hooks",
"flowtype", "flowtype",
"monorepo", "monorepo",
"import", "import",
"@stylistic/js" "@stylistic/js",
"unicorn"
], ],
"rules": { "rules": {
// Prettier is configured to keep lines to 80 chars, but there are two issues: // Prettier is configured to keep lines to 80 chars, but there are two issues:
// - It doesn't handle comments (leaves them as-is) // - It doesn't handle comments (leaves them as-is)
// - It makes all import statements take one line (reformats them) // - It makes all import statements take one line (reformats them)
// We want ESLint to warn us in the first case, but not in the second case // We want ESLint to warn us in the first case, but not in the second case
// since Prettier forces us in the second case. By setting code to 5000, we // since Prettier forces us in the second case. By setting code to 5000, we
// make sure ESLint defers to Prettier for import statements. // make sure ESLint defers to Prettier for import statements.
Show All 27 Lines "rules": {
], ],
"prefer-const": "error", "prefer-const": "error",
"react/jsx-curly-brace-presence": [ "react/jsx-curly-brace-presence": [
"error", "error",
{ "props": "never", "children": "ignore" } { "props": "never", "children": "ignore" }
], ],
"eqeqeq": ["error", "always"], "eqeqeq": ["error", "always"],
"no-constant-condition": ["error", { "checkLoops": false }], "no-constant-condition": ["error", { "checkLoops": false }],
"consistent-return": "error" "consistent-return": "error",
"unicorn/filename-case": [
"error",
{
"case": "kebabCase",
"ignore": [".*_v.*\\.*\\.*\\.js", ".*ModuleSchema\\.js"]
}
]
}, },
"settings": { "settings": {
"react": { "react": {
"version": "detect" "version": "detect"
}, },
"import/ignore": ["react-native"], "import/ignore": ["react-native"],
"import/internal-regex": "^(lib|native|keyserver|web)/" "import/internal-regex": "^(lib|native|keyserver|web)/"
}, },
Show All 14 Lines