Page MenuHomePhabricator

[lib] Propagate MEMBER permissions to all chats in a community
ClosedPublic

Authored by ashoat on Aug 19 2024, 8:24 AM.
Tags
None
Referenced Files
F2766934: D13113.diff
Thu, Sep 19, 3:49 PM
Unknown Object (File)
Sat, Sep 14, 12:16 AM
Unknown Object (File)
Mon, Sep 9, 6:45 AM
Unknown Object (File)
Sun, Sep 8, 10:32 PM
Unknown Object (File)
Thu, Sep 5, 11:00 PM
Unknown Object (File)
Thu, Sep 5, 2:18 PM
Unknown Object (File)
Sat, Aug 31, 1:47 AM
Unknown Object (File)
Fri, Aug 30, 11:02 PM
Subscribers
None

Details

Summary

This addresses ENG-9054.

The issue is that in D13014, I return false from includeThreadPermissionForThreadType even if a propagation prefix is set.

We want role permissions to apply to all chats in a community, even if there is a "broken link" where you are a member of a grandchild but not a member of its parent.

Depends on D13112

Test Plan
  1. I set up a repro of the issue in my local environment
  2. I applied this diff to fix the issue
  3. I reset db_version to 67 to trigger migration 68 again
  4. After migration 68 ran again, I confirmed that the issue was gone

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable