Page MenuHomePhabricator
Differential D13171

[lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`
ClosedPublic
Actions

Authored by kamil on Aug 26 2024, 9:09 AM.
Tags
None
Referenced Files
F3194779: D13171.id43908.diff
Sat, Nov 9, 12:22 AM
F3193260: D13171.id.diff
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:44 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Tue, Oct 29, 7:03 PM
Unknown Object (File)
Tue, Oct 22, 1:18 PM
Unknown Object (File)
Tue, Oct 22, 10:23 AM
Unknown Object (File)
Tue, Oct 22, 10:23 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`
Summary

https://phab.comm.dev/D13025#inline-75566

Test Plan

Build app, Flow, search for usage of SESSION_DOES_NOT_EXISTS and sessionDoesNotExists to make sure all are removed

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 26 2024, 9:09 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 26 2024, 9:09 AM
Harbormaster failed remote builds in B31270: Diff 43662!Aug 26 2024, 9:30 AM
kamil updated this revision to Diff 43665.Aug 27 2024, 2:16 AM

update

Harbormaster completed remote builds in B31273: Diff 43665.Aug 27 2024, 2:33 AM
kamil published this revision for review.Aug 28 2024, 5:56 AM
tomek accepted this revision.Aug 28 2024, 6:24 AM
This revision is now accepted and ready to land.Aug 28 2024, 6:24 AM
kamil mentioned this in D13025: [web][native] unify errors from `CryptoModule` on web and native.Sep 6 2024, 1:06 AM
kamil updated this revision to Diff 43908.Sep 6 2024, 1:21 AM

rebase

Harbormaster completed remote builds in B31444: Diff 43908.Sep 6 2024, 1:49 AM
Closed by commit rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST` (authored by kamil). · Explain WhySep 6 2024, 1:51 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
4 lines
utils/
2 lines
native/
cpp/
CommonCpp/
CryptoTools/
6 lines
web/
shared-worker/
worker/
8 lines

Diff 43908

View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...
View Options

lib/utils/olm-utils.js

Loading...
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...