[lib] mark messages as sent when there is no `messageID` in Outbound messages table
ClosedPublic
Actions

Authored by kamil on Fri, Sep 6, 4:28 AM.

Details

Reviewers

Commits

rCOMMa4a7448b12a3: [lib] mark messages as sent when there is no `messageID` in Outbound messages…

Summary

Handle edge-case when the message was sent, but it wasn't updated in the message store (e.g. app was killed), but was already confirmed by the other peer - and when hitting retry there is no message with given ID in the outbound messages table.

Test Plan

Test case described in summary.

Diff Detail

Repository

rCOMM Comm

Branch

tb-followups

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Fri, Sep 6, 4:28 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 6, 4:28 AM

kamil edited the summary of this revision. (Show Details)Fri, Sep 6, 4:29 AM

Harbormaster completed remote builds in B31448: Diff 43913.Fri, Sep 6, 4:57 AM

kamil published this revision for review.Fri, Sep 6, 5:36 AM

tomek accepted this revision.Fri, Sep 6, 7:58 AM

This revision is now accepted and ready to land.Fri, Sep 6, 7:58 AM

Closed by commit rCOMMa4a7448b12a3: [lib] mark messages as sent when there is no `messageID` in Outbound messages… (authored by kamil). · Explain WhyTue, Sep 10, 5:51 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa4a7448b12a3: [lib] mark messages as sent when there is no `messageID` in Outbound messages….

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

15 lines

Diff 43913

View Options

lib/tunnelbroker/peer-to-peer-context.js

[lib] mark messages as sent when there is no `messageID` in Outbound messages tableClosedPublicActions