Page MenuHomePhabricator

Enhance DMActivityHandler
ClosedPublic

Authored by marcin on Sep 12 2024, 5:59 AM.
Tags
None
Referenced Files
F3174694: D13305.diff
Thu, Nov 7, 5:39 PM
F3173341: D13305.id.diff
Thu, Nov 7, 3:15 PM
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Tue, Oct 22, 5:33 AM
Unknown Object (File)
Mon, Oct 21, 9:48 PM
Unknown Object (File)
Mon, Oct 14, 2:56 PM
Unknown Object (File)
Mon, Oct 14, 2:55 PM
Unknown Object (File)
Mon, Oct 14, 2:28 PM
Subscribers
None

Details

Summary

This differential addresses Ashoat review for this diff: https://phab.comm.dev/D13246

Test Plan
  1. Create thick thread between users A and B.
  2. Log in as user A on two devices (on web and on native) and log in as user B on third device.
  3. Send message from B to A. Open the thread as A on web. Ensure rescinding happens on native.
  4. Open the thread as A on native. Change opened thread as A on web. Send messages from B to A. Ensure that thread remains read on web.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9171
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

The active selector probably could've been factored out as well, and this diff probably could've been split up a bit. But at this point let's just land this work... I've given you enough additional things to worry about as-is

This revision is now accepted and ready to land.Sep 12 2024, 8:25 AM
This revision was landed with ongoing or failed builds.Sep 12 2024, 10:23 AM
This revision was automatically updated to reflect the committed changes.