[native] Fix Comm swoosh render in RegistrationTerms on iOS release builds
ClosedPublic
Actions

Authored by ashoat on Sep 12 2024, 11:10 AM.

Details

Reviewers

varun
will

Commits

rCOMMeac9bad33a03: [native] Fix Comm swoosh render in RegistrationTerms on iOS release builds

Summary

For some reason, center works on iOS debug builds, but not release builds. This diff makes it look good on release builds.

center is probably closer to what we want than contain, but they have the same behavior because the swoosh is larger than the screen width and as such doesn't need to be centered.

Depends on D13311

Test Plan

before	after

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 12 2024, 11:10 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 12 2024, 11:10 AM

ashoat edited the test plan for this revision. (Show Details)Sep 12 2024, 11:10 AM

Harbormaster completed remote builds in B31579: Diff 44112.Sep 12 2024, 11:29 AM

ashoat requested review of this revision.Sep 12 2024, 11:29 AM

varun accepted this revision.Sep 12 2024, 4:45 PM

This revision is now accepted and ready to land.Sep 12 2024, 4:45 PM

Closed by commit rCOMMeac9bad33a03: [native] Fix Comm swoosh render in RegistrationTerms on iOS release builds (authored by ashoat). · Explain WhySep 13 2024, 7:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMeac9bad33a03: [native] Fix Comm swoosh render in RegistrationTerms on iOS release builds.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-terms.react.js

2 lines

Diff 44180

View Options

native/account/registration/registration-terms.react.js

[native] Fix Comm swoosh render in RegistrationTerms on iOS release buildsClosedPublicActions