Page MenuHomePhabricator
Differential D13309

[native] Make Farcaster login optional
ClosedPublic
Actions

Authored by ashoat on Sep 12 2024, 11:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 4:59 AM
Unknown Object (File)
Wed, Feb 26, 11:37 AM
Unknown Object (File)
Wed, Feb 26, 10:49 AM
Unknown Object (File)
Fri, Feb 14, 6:53 AM
Unknown Object (File)
Jan 31 2025, 7:47 PM
Unknown Object (File)
Jan 31 2025, 7:47 PM
Unknown Object (File)
Jan 31 2025, 7:46 PM
Unknown Object (File)
Dec 31 2024, 11:41 AM
View All 47 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM45d761b309c9: [native] Make Farcaster login optional
Summary

Apple won't let us launch with Farcaster login required as it's against their App Store Guidelines.

Depends on D13308

Test Plan

Confirmed that the "skip" button shows up on release builds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
registration/
27 lines
components/
2 lines
13 lines
profile/
2 lines

Diff 44177

View Options

native/account/registration/connect-farcaster.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines
View Options

native/components/connect-farcaster-bottom-sheet.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines
View Options

native/components/farcaster-prompt.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines
View Options

native/profile/farcaster-account-settings.react.js

Show All 36 Lines
import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js'; import { extractUserIDsFromPayload } from '../../utils/conversion-utils.js';
import { useSelector, useDispatch } from '../../utils/redux-utils.js'; import { useSelector, useDispatch } from '../../utils/redux-utils.js';
import { messageSpecs } from '../messages/message-specs.js'; import { messageSpecs } from '../messages/message-specs.js';
import { updateSpecs } from '../updates/update-specs.js'; import { updateSpecs } from '../updates/update-specs.js';
function useSendDMOperationUtils(): ProcessDMOperationUtilities { function useSendDMOperationUtils(): ProcessDMOperationUtilities {
const fetchMessage = useGetLatestMessageEdit(); const fetchMessage = useGetLatestMessageEdit();
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
const entryInfos = useSelector(state => state.entryStore.entryInfos);
return React.useMemo( return React.useMemo(
() => ({ () => ({
fetchMessage, fetchMessage,
threadInfos, threadInfos,
entryInfos,
}), }),
[fetchMessage, threadInfos], [fetchMessage, threadInfos, entryInfos],
); );
} }
function useProcessDMOperation(): ( function useProcessDMOperation(): (
dmOperationSpecification: DMOperationSpecification, dmOperationSpecification: DMOperationSpecification,
dmOpID: ?string, dmOpID: ?string,
) => Promise<void> { ) => Promise<void> {
const threadInfos = useSelector(state => state.threadStore.threadInfos); const threadInfos = useSelector(state => state.threadStore.threadInfos);
▲ Show 20 Lines • Show All 344 Lines • Show Last 20 Lines