This differential fixes this bug. All decryption methods take message type as argument. The only exception are the top level methods that decrypt notifs from the keyserver
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-9265
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Would be good for somebody more familiar with notif-crypto-utils.js to review
| web/push-notif/notif-crypto-utils.js | ||
|---|---|---|
| 418 ↗ | (On Diff #44233) | How do we know this will always be TEXT? |
| 549 ↗ | (On Diff #44233) | How do we know this will always be TEXT? |
| 786 ↗ | (On Diff #44233) | What's the context on this change? Seems like it should be a separate diff |
| web/push-notif/notif-crypto-utils.js | ||
|---|---|---|
| 716–719 ↗ | (On Diff #44233) | It will be easy to forget about updating this place while introducing a new message type. We should probably introduce a function that takes a string, returns OlmEncryptedMessageTypes, and asserts. |
| web/push-notif/notif-crypto-utils.js | ||
|---|---|---|
| 418 ↗ | (On Diff #44233) | Keyserver notifications are one-way, ane the keyserver is the inbound. Therefore the only prekey message is the initial encrypted send by the client. Not that this is not new hardcoding but rather moving hardcoding to higher level place. |
| 549 ↗ | (On Diff #44233) | Same as above |
| 716–719 ↗ | (On Diff #44233) | Okay, but it is very unlikely that we will introduce new type since those types come from olm protocol. |
| 786 ↗ | (On Diff #44233) | I've just realised that we don't delete one time key after creating inbound session. Okay - I will create new diff. This change is also necessary on native. |