[lib] refactor methods from `PeerToPeerContext` to utils
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 5:09 AM.

Details

Reviewers

bartek
tomek
marcin

Commits

rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils

Summary

ENG-9106.

The code in Context is messy and complicated, moving this to methods to make it clean. See usages in next diff - I am going to link source code from Githb to make it easier for review.

Depends on D13373

Test Plan

Tested in D13376

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 18 2024, 5:09 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 5:09 AM

kamil added a child revision: D13376: [lib] refactor sending `OutboundP2PMessages` to peers.Sep 18 2024, 5:15 AM

Harbormaster completed remote builds in B31682: Diff 44292.Sep 18 2024, 5:26 AM

kamil added inline comments.Sep 18 2024, 5:41 AM

lib/utils/peer-to-peer-communication-utils.js
22–61 ↗	(On Diff #44292)	code here
63–92 ↗	(On Diff #44292)	code here and here
94–134 ↗	(On Diff #44292)	code here but most of it is already extracted to functions above
136–182 ↗	(On Diff #44292)	code here and here.