[lib] Retry Tunnelbroker connection after closing
ClosedPublic
Actions

Authored by bartek on Sep 18 2024, 6:38 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM6cd543112f87: [lib] Retry Tunnelbroker connection after closing

Summary

Details in ENG-9246.
Added a retry counter variable and a timeout.

The effect hook has dependency on this variable
It is increased after each retry
Retry has to have interval to avoid infinite effect loop. Defaulted to 5s

Previously, effect wasn't triggered if socketState.connected was already false. Change false -> false doesn't trigger the hook, so socket wasn't recreated.

Test Plan

On native: Turned airplane mode on/off.
On web: turned wifi on/off.

Observed console logs. The connection was successfully restored after network coming back.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 18 2024, 6:38 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 6:38 AM

Harbormaster failed remote builds in B31691: Diff 44301!Sep 18 2024, 6:51 AM

bartek published this revision for review.Sep 18 2024, 7:59 AM

Fix flow

Harbormaster completed remote builds in B31701: Diff 44315.Sep 18 2024, 8:19 AM

bartek added inline comments.Sep 18 2024, 8:40 AM

lib/tunnelbroker/tunnelbroker-context.js
293–296 ↗	(On Diff #44315)	Actually should be 0, we don't retry here

kamil accepted this revision.Sep 18 2024, 9:59 AM

kamil added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
91 ↗	(On Diff #44315)	I am thinking about less time here, e.g. for the keyserver we have `export const clientKeyserverSocketReconnectDelay = 2000;` but not sure