[lib] Introduce DMRelationshipOperation
ClosedPublic
Actions

Authored by ashoat on Sep 19 2024, 3:43 PM.

Details

Reviewers

tomek
kamil
will

Commits

rCOMM78d32f06fdd5: [lib] Introduce DMRelationshipOperation

Summary

Types for ENG-9329.

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 19 2024, 3:43 PM

ashoat added a child revision: D13390: [lib] Introduce findUserIdentities to ProcessDMOperationUtilities.

Harbormaster completed remote builds in B31717: Diff 44347.Sep 19 2024, 4:00 PM

ashoat requested review of this revision.Sep 19 2024, 4:00 PM

kamil accepted this revision.Sep 20 2024, 1:30 AM

kamil added inline comments.

lib/types/dm-ops.js
453–474 ↗	(On Diff #44347)	nit: I think we usually want to not add an extra line between type and validator - but it looks like this convention is not maintained for entries

This revision is now accepted and ready to land.Sep 20 2024, 1:30 AM

Remove spaces

This revision was landed with ongoing or failed builds.Sep 20 2024, 6:16 AM

Closed by commit rCOMM78d32f06fdd5: [lib] Introduce DMRelationshipOperation (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM78d32f06fdd5: [lib] Introduce DMRelationshipOperation.

Harbormaster completed remote builds in B31735: Diff 44365.Sep 20 2024, 6:30 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

dm-ops.js

31 lines

messages/

update-relationship.js

4 lines

Diff 44365

View Options

lib/types/dm-ops.js