Page MenuHomePhabricator
Differential D13390

[lib] Introduce findUserIdentities to ProcessDMOperationUtilities
ClosedPublic
Actions

Authored by ashoat on Sep 19 2024, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 3:04 PM
Unknown Object (File)
Fri, Feb 28, 9:26 AM
Unknown Object (File)
Fri, Feb 28, 8:12 AM
Unknown Object (File)
Feb 20 2025, 10:24 PM
Unknown Object (File)
Feb 19 2025, 6:47 AM
Unknown Object (File)
Feb 18 2025, 11:06 AM
Unknown Object (File)
Feb 13 2025, 8:14 AM
Unknown Object (File)
Jan 25 2025, 6:57 PM
View All 54 Files
Subscribers
None

Details

Reviewers
tomek
kamil
will
Commits
rCOMM233ae45c5c70: [lib] Introduce findUserIdentities to ProcessDMOperationUtilities
Summary

This goes through UserIdentityCache, so we are guaranteed that multiple fetches for the same user ID will result in at most a single identity call.

Depends on D13389

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
4 lines
9 lines

Diff 44368

View Options

lib/shared/dm-ops/dm-op-spec.js

// @flow // @flow
import t, { type TInterface, type TUnion } from 'tcomb'; import t, { type TInterface, type TUnion } from 'tcomb';
import { clientAvatarValidator, type ClientAvatar } from './avatar-types.js'; import { clientAvatarValidator, type ClientAvatar } from './avatar-types.js';
import { type Media, mediaValidator } from './media-types.js'; import { type Media, mediaValidator } from './media-types.js';
import type { RawMessageInfo } from './message-types.js'; import type { RawMessageInfo } from './message-types.js';
import type { RelationshipOperation } from './messages/update-relationship.js';
import type { NotificationsCreationData } from './notif-types.js'; import type { NotificationsCreationData } from './notif-types.js';
import type { OutboundP2PMessage } from './sqlite-types.js'; import type { OutboundP2PMessage } from './sqlite-types.js';
import { import {
type ThreadSubscription, type ThreadSubscription,
threadSubscriptionValidator, threadSubscriptionValidator,
} from './subscription-types.js'; } from './subscription-types.js';
import { import {
type NonSidebarThickThreadType, type NonSidebarThickThreadType,
Show All 22 Linesexport const dmOperationTypes = Object.freeze({
LEAVE_THREAD: 'leave_thread', LEAVE_THREAD: 'leave_thread',
REMOVE_MEMBERS: 'remove_members', REMOVE_MEMBERS: 'remove_members',
CHANGE_THREAD_SETTINGS: 'change_thread_settings', CHANGE_THREAD_SETTINGS: 'change_thread_settings',
CHANGE_THREAD_SUBSCRIPTION: 'change_thread_subscription', CHANGE_THREAD_SUBSCRIPTION: 'change_thread_subscription',
CHANGE_THREAD_READ_STATUS: 'change_thread_read_status', CHANGE_THREAD_READ_STATUS: 'change_thread_read_status',
CREATE_ENTRY: 'create_entry', CREATE_ENTRY: 'create_entry',
DELETE_ENTRY: 'delete_entry', DELETE_ENTRY: 'delete_entry',
EDIT_ENTRY: 'edit_entry', EDIT_ENTRY: 'edit_entry',
UPDATE_RELATIONSHIP: 'update_relationship',
}); });
export type DMOperationType = $Values<typeof dmOperationTypes>; export type DMOperationType = $Values<typeof dmOperationTypes>;
type MemberIDWithSubscription = { type MemberIDWithSubscription = {
+id: string, +id: string,
+subscription: ThreadSubscription, +subscription: ThreadSubscription,
}; };
export const memberIDWithSubscriptionValidator: TInterface<MemberIDWithSubscription> = export const memberIDWithSubscriptionValidator: TInterface<MemberIDWithSubscription> =
▲ Show 20 Lines • Show All 326 Lines • ▼ Show 20 Linesexport type DMCreateEntryOperation = {
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+text: string, +text: string,
+messageID: string, +messageID: string,
}; };
export const dmCreateEntryOperationValidator: TInterface<DMCreateEntryOperation> = export const dmCreateEntryOperationValidator: TInterface<DMCreateEntryOperation> =
tShape<DMCreateEntryOperation>({ tShape<DMCreateEntryOperation>({
type: tString(dmOperationTypes.CREATE_ENTRY), type: tString(dmOperationTypes.CREATE_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
time: t.Number, time: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
text: t.String, text: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMDeleteEntryOperation = { export type DMDeleteEntryOperation = {
+type: 'delete_entry', +type: 'delete_entry',
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+creationTime: number, +creationTime: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+prevText: string, +prevText: string,
+messageID: string, +messageID: string,
}; };
export const dmDeleteEntryOperationValidator: TInterface<DMDeleteEntryOperation> = export const dmDeleteEntryOperationValidator: TInterface<DMDeleteEntryOperation> =
tShape<DMDeleteEntryOperation>({ tShape<DMDeleteEntryOperation>({
type: tString(dmOperationTypes.DELETE_ENTRY), type: tString(dmOperationTypes.DELETE_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
time: t.Number, time: t.Number,
creationTime: t.Number, creationTime: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
prevText: t.String, prevText: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMEditEntryOperation = { export type DMEditEntryOperation = {
+type: 'edit_entry', +type: 'edit_entry',
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+creationTime: number, +creationTime: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+text: string, +text: string,
+messageID: string, +messageID: string,
}; };
export const dmEditEntryOperationValidator: TInterface<DMEditEntryOperation> = export const dmEditEntryOperationValidator: TInterface<DMEditEntryOperation> =
tShape<DMEditEntryOperation>({ tShape<DMEditEntryOperation>({
type: tString(dmOperationTypes.EDIT_ENTRY), type: tString(dmOperationTypes.EDIT_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
creationTime: t.Number, creationTime: t.Number,
time: t.Number, time: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
text: t.String, text: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMUpdateRelationshipOperation = {
+type: 'update_relationship',
+threadID: string,
+creatorID: string,
+time: number,
+operation: RelationshipOperation,
+messageID: string,
};
export const dmUpdateRelationshipOperationValidator: TInterface<DMUpdateRelationshipOperation> =
tShape<DMUpdateRelationshipOperation>({
type: tString(dmOperationTypes.UPDATE_RELATIONSHIP),
threadID: t.String,
creatorID: t.String,
time: t.Number,
operation: t.enums.of([
'request_sent',
'request_accepted',
'farcaster_mutual',
]),
messageID: t.String,
});
export type DMOperation = export type DMOperation =
| DMCreateThreadOperation | DMCreateThreadOperation
| DMCreateSidebarOperation | DMCreateSidebarOperation
| DMSendTextMessageOperation | DMSendTextMessageOperation
| DMSendMultimediaMessageOperation | DMSendMultimediaMessageOperation
| DMSendReactionMessageOperation | DMSendReactionMessageOperation
| DMSendEditMessageOperation | DMSendEditMessageOperation
| DMAddMembersOperation | DMAddMembersOperation
| DMAddViewerToThreadMembersOperation | DMAddViewerToThreadMembersOperation
| DMJoinThreadOperation | DMJoinThreadOperation
| DMLeaveThreadOperation | DMLeaveThreadOperation
| DMRemoveMembersOperation | DMRemoveMembersOperation
| DMChangeThreadSettingsOperation | DMChangeThreadSettingsOperation
| DMChangeThreadSubscriptionOperation | DMChangeThreadSubscriptionOperation
| DMChangeThreadReadStatusOperation | DMChangeThreadReadStatusOperation
| DMCreateEntryOperation | DMCreateEntryOperation
| DMDeleteEntryOperation | DMDeleteEntryOperation
| DMEditEntryOperation; | DMEditEntryOperation
| DMUpdateRelationshipOperation;
export const dmOperationValidator: TUnion<DMOperation> = t.union([ export const dmOperationValidator: TUnion<DMOperation> = t.union([
dmCreateThreadOperationValidator, dmCreateThreadOperationValidator,
dmCreateSidebarOperationValidator, dmCreateSidebarOperationValidator,
dmSendTextMessageOperationValidator, dmSendTextMessageOperationValidator,
dmSendMultimediaMessageOperationValidator, dmSendMultimediaMessageOperationValidator,
dmSendReactionMessageOperationValidator, dmSendReactionMessageOperationValidator,
dmSendEditMessageOperationValidator, dmSendEditMessageOperationValidator,
dmAddMembersOperationValidator, dmAddMembersOperationValidator,
dmAddViewerToThreadMembersValidator, dmAddViewerToThreadMembersValidator,
dmJoinThreadOperationValidator, dmJoinThreadOperationValidator,
dmLeaveThreadOperationValidator, dmLeaveThreadOperationValidator,
dmRemoveMembersOperationValidator, dmRemoveMembersOperationValidator,
dmChangeThreadSettingsOperationValidator, dmChangeThreadSettingsOperationValidator,
dmChangeThreadSubscriptionOperationValidator, dmChangeThreadSubscriptionOperationValidator,
dmChangeThreadReadStatusOperationValidator, dmChangeThreadReadStatusOperationValidator,
dmCreateEntryOperationValidator, dmCreateEntryOperationValidator,
dmDeleteEntryOperationValidator, dmDeleteEntryOperationValidator,
dmEditEntryOperationValidator, dmEditEntryOperationValidator,
dmUpdateRelationshipOperationValidator,
]); ]);
export type DMOperationResult = { export type DMOperationResult = {
rawMessageInfos: Array<RawMessageInfo>, rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>, updateInfos: Array<ClientUpdateInfo>,
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/process-dm-ops.js

// @flow // @flow
import t, { type TInterface, type TUnion } from 'tcomb'; import t, { type TInterface, type TUnion } from 'tcomb';
import { clientAvatarValidator, type ClientAvatar } from './avatar-types.js'; import { clientAvatarValidator, type ClientAvatar } from './avatar-types.js';
import { type Media, mediaValidator } from './media-types.js'; import { type Media, mediaValidator } from './media-types.js';
import type { RawMessageInfo } from './message-types.js'; import type { RawMessageInfo } from './message-types.js';
import type { RelationshipOperation } from './messages/update-relationship.js';
import type { NotificationsCreationData } from './notif-types.js'; import type { NotificationsCreationData } from './notif-types.js';
import type { OutboundP2PMessage } from './sqlite-types.js'; import type { OutboundP2PMessage } from './sqlite-types.js';
import { import {
type ThreadSubscription, type ThreadSubscription,
threadSubscriptionValidator, threadSubscriptionValidator,
} from './subscription-types.js'; } from './subscription-types.js';
import { import {
type NonSidebarThickThreadType, type NonSidebarThickThreadType,
Show All 22 Linesexport const dmOperationTypes = Object.freeze({
LEAVE_THREAD: 'leave_thread', LEAVE_THREAD: 'leave_thread',
REMOVE_MEMBERS: 'remove_members', REMOVE_MEMBERS: 'remove_members',
CHANGE_THREAD_SETTINGS: 'change_thread_settings', CHANGE_THREAD_SETTINGS: 'change_thread_settings',
CHANGE_THREAD_SUBSCRIPTION: 'change_thread_subscription', CHANGE_THREAD_SUBSCRIPTION: 'change_thread_subscription',
CHANGE_THREAD_READ_STATUS: 'change_thread_read_status', CHANGE_THREAD_READ_STATUS: 'change_thread_read_status',
CREATE_ENTRY: 'create_entry', CREATE_ENTRY: 'create_entry',
DELETE_ENTRY: 'delete_entry', DELETE_ENTRY: 'delete_entry',
EDIT_ENTRY: 'edit_entry', EDIT_ENTRY: 'edit_entry',
UPDATE_RELATIONSHIP: 'update_relationship',
}); });
export type DMOperationType = $Values<typeof dmOperationTypes>; export type DMOperationType = $Values<typeof dmOperationTypes>;
type MemberIDWithSubscription = { type MemberIDWithSubscription = {
+id: string, +id: string,
+subscription: ThreadSubscription, +subscription: ThreadSubscription,
}; };
export const memberIDWithSubscriptionValidator: TInterface<MemberIDWithSubscription> = export const memberIDWithSubscriptionValidator: TInterface<MemberIDWithSubscription> =
▲ Show 20 Lines • Show All 326 Lines • ▼ Show 20 Linesexport type DMCreateEntryOperation = {
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+text: string, +text: string,
+messageID: string, +messageID: string,
}; };
export const dmCreateEntryOperationValidator: TInterface<DMCreateEntryOperation> = export const dmCreateEntryOperationValidator: TInterface<DMCreateEntryOperation> =
tShape<DMCreateEntryOperation>({ tShape<DMCreateEntryOperation>({
type: tString(dmOperationTypes.CREATE_ENTRY), type: tString(dmOperationTypes.CREATE_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
time: t.Number, time: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
text: t.String, text: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMDeleteEntryOperation = { export type DMDeleteEntryOperation = {
+type: 'delete_entry', +type: 'delete_entry',
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+creationTime: number, +creationTime: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+prevText: string, +prevText: string,
+messageID: string, +messageID: string,
}; };
export const dmDeleteEntryOperationValidator: TInterface<DMDeleteEntryOperation> = export const dmDeleteEntryOperationValidator: TInterface<DMDeleteEntryOperation> =
tShape<DMDeleteEntryOperation>({ tShape<DMDeleteEntryOperation>({
type: tString(dmOperationTypes.DELETE_ENTRY), type: tString(dmOperationTypes.DELETE_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
time: t.Number, time: t.Number,
creationTime: t.Number, creationTime: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
prevText: t.String, prevText: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMEditEntryOperation = { export type DMEditEntryOperation = {
+type: 'edit_entry', +type: 'edit_entry',
+threadID: string, +threadID: string,
+creatorID: string, +creatorID: string,
+time: number, +time: number,
+creationTime: number, +creationTime: number,
+entryID: string, +entryID: string,
+entryDate: string, +entryDate: string,
+text: string, +text: string,
+messageID: string, +messageID: string,
}; };
export const dmEditEntryOperationValidator: TInterface<DMEditEntryOperation> = export const dmEditEntryOperationValidator: TInterface<DMEditEntryOperation> =
tShape<DMEditEntryOperation>({ tShape<DMEditEntryOperation>({
type: tString(dmOperationTypes.EDIT_ENTRY), type: tString(dmOperationTypes.EDIT_ENTRY),
threadID: t.String, threadID: t.String,
creatorID: t.String, creatorID: t.String,
creationTime: t.Number, creationTime: t.Number,
time: t.Number, time: t.Number,
entryID: t.String, entryID: t.String,
entryDate: t.String, entryDate: t.String,
text: t.String, text: t.String,
messageID: t.String, messageID: t.String,
}); });
export type DMUpdateRelationshipOperation = {
+type: 'update_relationship',
+threadID: string,
+creatorID: string,
+time: number,
+operation: RelationshipOperation,
+messageID: string,
};
export const dmUpdateRelationshipOperationValidator: TInterface<DMUpdateRelationshipOperation> =
tShape<DMUpdateRelationshipOperation>({
type: tString(dmOperationTypes.UPDATE_RELATIONSHIP),
threadID: t.String,
creatorID: t.String,
time: t.Number,
operation: t.enums.of([
'request_sent',
'request_accepted',
'farcaster_mutual',
]),
messageID: t.String,
});
export type DMOperation = export type DMOperation =
| DMCreateThreadOperation | DMCreateThreadOperation
| DMCreateSidebarOperation | DMCreateSidebarOperation
| DMSendTextMessageOperation | DMSendTextMessageOperation
| DMSendMultimediaMessageOperation | DMSendMultimediaMessageOperation
| DMSendReactionMessageOperation | DMSendReactionMessageOperation
| DMSendEditMessageOperation | DMSendEditMessageOperation
| DMAddMembersOperation | DMAddMembersOperation
| DMAddViewerToThreadMembersOperation | DMAddViewerToThreadMembersOperation
| DMJoinThreadOperation | DMJoinThreadOperation
| DMLeaveThreadOperation | DMLeaveThreadOperation
| DMRemoveMembersOperation | DMRemoveMembersOperation
| DMChangeThreadSettingsOperation | DMChangeThreadSettingsOperation
| DMChangeThreadSubscriptionOperation | DMChangeThreadSubscriptionOperation
| DMChangeThreadReadStatusOperation | DMChangeThreadReadStatusOperation
| DMCreateEntryOperation | DMCreateEntryOperation
| DMDeleteEntryOperation | DMDeleteEntryOperation
| DMEditEntryOperation; | DMEditEntryOperation
| DMUpdateRelationshipOperation;
export const dmOperationValidator: TUnion<DMOperation> = t.union([ export const dmOperationValidator: TUnion<DMOperation> = t.union([
dmCreateThreadOperationValidator, dmCreateThreadOperationValidator,
dmCreateSidebarOperationValidator, dmCreateSidebarOperationValidator,
dmSendTextMessageOperationValidator, dmSendTextMessageOperationValidator,
dmSendMultimediaMessageOperationValidator, dmSendMultimediaMessageOperationValidator,
dmSendReactionMessageOperationValidator, dmSendReactionMessageOperationValidator,
dmSendEditMessageOperationValidator, dmSendEditMessageOperationValidator,
dmAddMembersOperationValidator, dmAddMembersOperationValidator,
dmAddViewerToThreadMembersValidator, dmAddViewerToThreadMembersValidator,
dmJoinThreadOperationValidator, dmJoinThreadOperationValidator,
dmLeaveThreadOperationValidator, dmLeaveThreadOperationValidator,
dmRemoveMembersOperationValidator, dmRemoveMembersOperationValidator,
dmChangeThreadSettingsOperationValidator, dmChangeThreadSettingsOperationValidator,
dmChangeThreadSubscriptionOperationValidator, dmChangeThreadSubscriptionOperationValidator,
dmChangeThreadReadStatusOperationValidator, dmChangeThreadReadStatusOperationValidator,
dmCreateEntryOperationValidator, dmCreateEntryOperationValidator,
dmDeleteEntryOperationValidator, dmDeleteEntryOperationValidator,
dmEditEntryOperationValidator, dmEditEntryOperationValidator,
dmUpdateRelationshipOperationValidator,
]); ]);
export type DMOperationResult = { export type DMOperationResult = {
rawMessageInfos: Array<RawMessageInfo>, rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>, updateInfos: Array<ClientUpdateInfo>,
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines