Page MenuHomePhabricator
Differential D13390

[lib] Introduce findUserIdentities to ProcessDMOperationUtilities
ClosedPublic
Actions

Authored by ashoat on Sep 19 2024, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 3:04 PM
Unknown Object (File)
Fri, Feb 28, 9:26 AM
Unknown Object (File)
Fri, Feb 28, 8:12 AM
Unknown Object (File)
Feb 20 2025, 10:24 PM
Unknown Object (File)
Feb 19 2025, 6:47 AM
Unknown Object (File)
Feb 18 2025, 11:06 AM
Unknown Object (File)
Feb 13 2025, 8:14 AM
Unknown Object (File)
Jan 25 2025, 6:57 PM
View All 54 Files
Subscribers
None

Details

Reviewers
tomek
kamil
will
Commits
rCOMM233ae45c5c70: [lib] Introduce findUserIdentities to ProcessDMOperationUtilities
Summary

This goes through UserIdentityCache, so we are guaranteed that multiple fetches for the same user ID will result in at most a single identity call.

Depends on D13389

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
4 lines
9 lines

Diff 44348

View Options

lib/shared/dm-ops/dm-op-spec.js

require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking") require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods") require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules") require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")
platform :ios, '13.0' platform :ios, '13.0'
install! 'cocoapods', :deterministic_uuids => false install! 'cocoapods', :deterministic_uuids => false
require 'json' require 'json'
def common_comm_target_pods def common_comm_target_pods
pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation' pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'
pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video' pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video'
pod 'ffmpeg-kit-react-native', :subspecs => ['min'], :podspec => '../node_modules/ffmpeg-kit-react-native'
end end
post_integrate do |installer| post_integrate do |installer|
begin begin
expo_patch_react_imports!(installer) expo_patch_react_imports!(installer)
rescue => e rescue => e
Pod::UI.warn e Pod::UI.warn e
end end
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/process-dm-ops.js

require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking") require File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods") require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules") require File.join(File.dirname(`node --print "require.resolve('@react-native-community/cli-platform-ios/package.json')"`), "native_modules")
platform :ios, '13.0' platform :ios, '13.0'
install! 'cocoapods', :deterministic_uuids => false install! 'cocoapods', :deterministic_uuids => false
require 'json' require 'json'
def common_comm_target_pods def common_comm_target_pods
pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation' pod 'SQLCipher-Amalgamation', :path => '../../node_modules/@commapp/sqlcipher-amalgamation'
pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video' pod 'react-native-video/VideoCaching', :podspec => '../node_modules/react-native-video'
pod 'ffmpeg-kit-react-native', :subspecs => ['min'], :podspec => '../node_modules/ffmpeg-kit-react-native'
end end
post_integrate do |installer| post_integrate do |installer|
begin begin
expo_patch_react_imports!(installer) expo_patch_react_imports!(installer)
rescue => e rescue => e
Pod::UI.warn e Pod::UI.warn e
end end
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines