Page MenuHomePhabricator
Differential D13392

[lib] Introduce updateRelationshipSpec
Needs ReviewPublic
Actions

Authored by ashoat on Thu, Sep 19, 3:47 PM.

Details

Reviewers
tomek
kamil
will
Summary

This addresses ENG-9329.

Depends on D13391

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Thu, Sep 19, 3:47 PM
ashoat added inline comments.Thu, Sep 19, 3:53 PM
lib/shared/dm-ops/update-relationship-spec.js
103

One thing I'm curious about is whether we should introduce a new queue for FIDs / AuxUserStore

Arguably we've derisked the possibility of a scenario where the message comes in before FarcasterDataHandler has a chance to update the AuxUserStore, since we're relying on findUserIdentities calls instead of AuxUserStore

Harbormaster completed remote builds in B31720: Diff 44350.Thu, Sep 19, 4:04 PM
ashoat requested review of this revision.Thu, Sep 19, 4:04 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
110 lines

Diff 44350

View Options

lib/shared/dm-ops/dm-op-specs.js

Loading...
View Options

lib/shared/dm-ops/update-relationship-spec.js

Loading...