Page MenuHomePhabricator

[lib] Avoid unnecessary sets creation
ClosedPublic

Authored by tomek on Fri, Sep 20, 2:09 AM.
Tags
None
Referenced Files
F2844244: D13400.diff
Sun, Sep 29, 7:21 PM
F2843212: D13400.id44399.diff
Sun, Sep 29, 4:08 PM
F2839320: D13400.id44398.diff
Sun, Sep 29, 1:24 AM
F2838091: D13400.id44359.diff
Sat, Sep 28, 8:38 PM
Unknown Object (File)
Sat, Sep 28, 5:51 PM
Unknown Object (File)
Fri, Sep 27, 11:57 PM
Unknown Object (File)
Fri, Sep 27, 3:21 PM
Unknown Object (File)
Thu, Sep 26, 4:42 AM
Subscribers

Details

Summary

We don't need to create sets for the queues - we can as effectively check the object keys. The benefit of the new approach is that we don't perform a linear amount of work when new entities appear.

Test Plan
  1. Created an operation with a reaction that was received before an operation creating the message
  2. Created an operation with an entry edit that was received before an operation creating the entry
  3. Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable