Page MenuHomePhabricator

[lib] Take operations from the queue when conditions become met
ClosedPublic

Authored by tomek on Sep 18 2024, 5:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:02 AM
Unknown Object (File)
Wed, Nov 20, 6:39 AM
Unknown Object (File)
Oct 22 2024, 10:41 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 20 2024, 7:45 PM
Subscribers

Details

Summary

Check the conditions, take from the queues, process and dispatch actions.

https://linear.app/comm/issue/ENG-9189/introduce-additional-operation-queues

Depends on D13366

Test Plan

Tested the whole stack at once:

  1. Created an operation with a reaction that was received before an operation creating the message
  2. Created an operation with an edit that was received before an operation creating the message
  3. Created an operation with an entry edit that was received before an operation creating the entry
  4. Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Sep 18 2024, 5:31 AM
This revision is now accepted and ready to land.Sep 18 2024, 9:54 AM
lib/shared/dm-ops/dm-ops-queue-handler.react.js
51–57

This was inefficient - created a diff with improvements D13400