[lib] Update the conditions we check before processing the operations
ClosedPublic
Actions

Authored by tomek on Sep 17 2024, 8:47 AM.

Details

Reviewers

kamil
will

Commits

rCOMM25b472e3dbe5: [lib] Update the conditions we check before processing the operations

Summary

Queue operations when their dependencies aren't satisfied

https://linear.app/comm/issue/ENG-9189/introduce-additional-operation-queues

Depends on D13365

Test Plan

Tested the whole stack at once:

Created an operation with a reaction that was received before an operation creating the message
Created an operation with an edit that was received before an operation creating the message
Created an operation with an entry edit that was received before an operation creating the entry
Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 17 2024, 8:47 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 17 2024, 8:47 AM

tomek edited the summary of this revision. (Show Details)Sep 17 2024, 8:48 AM

tomek added a parent revision: D13365: [lib] Queue operations.

Harbormaster completed remote builds in B31671: Diff 44276.Sep 17 2024, 9:10 AM

tomek requested review of this revision.Sep 17 2024, 9:10 AM

tomek added a child revision: D13375: [lib] Take operations from the queue when conditions become met.Sep 18 2024, 5:14 AM

Update reaction message condition

Harbormaster completed remote builds in B31685: Diff 44295.Sep 18 2024, 5:46 AM

Fix edit message condition

tomek edited the test plan for this revision. (Show Details)Sep 18 2024, 6:57 AM

Harbormaster completed remote builds in B31692: Diff 44302.Sep 18 2024, 6:59 AM

kamil accepted this revision.Sep 18 2024, 9:50 AM

This revision is now accepted and ready to land.Sep 18 2024, 9:50 AM

Closed by commit rCOMM25b472e3dbe5: [lib] Update the conditions we check before processing the operations (authored by tomek). · Explain WhySep 19 2024, 4:15 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM25b472e3dbe5: [lib] Update the conditions we check before processing the operations.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

add-members-spec.js

4 lines

add-viewer-to-thread-members-spec.js

4 lines

change-thread-read-status-spec.js

4 lines

change-thread-settings-spec.js

4 lines

change-thread-subscription.js

9 lines

create-entry-spec.js

4 lines

create-sidebar-spec.js

18 lines

create-thread-spec.js

2 lines

20 lines

24 lines

20 lines

4 lines

4 lines

2 lines

remove-members-spec.js

4 lines

send-edit-message-spec.js

21 lines

send-multimedia-message-spec.js

4 lines

send-reaction-message-spec.js

21 lines

send-text-message-spec.js

4 lines

Diff 44342

View Options

lib/shared/dm-ops/add-members-spec.js

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines	(action.type === keyserverAuthActionTypes.success &&
state,		state,
action.payload.preRequestUserInfo,		action.payload.preRequestUserInfo,
action.payload.authActionSource,		action.payload.authActionSource,
))		))
) {		) {
return state;		return state;
}		}

		if (
		(action.type === logOutActionTypes.success \|\|
		action.type === deleteAccountActionTypes.success) &&
		identityInvalidSessionDowngrade(
		oldState,
		action.payload.currentUserInfo,
		action.payload.preRequestUserState,
		)
		) {
		return {
		...oldState,
		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
		};
		}

if (action.type === setInitialReduxState) {		if (action.type === setInitialReduxState) {
const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =		const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =
action.payload;		action.payload;
const replaceOperations: ReplaceKeyserverOperation[] = [];		const replaceOperations: ReplaceKeyserverOperation[] = [];
for (const keyserverID in keyserverInfos) {		for (const keyserverID in keyserverInfos) {
replaceOperations.push({		replaceOperations.push({
type: 'replace_keyserver',		type: 'replace_keyserver',
payload: {		payload: {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines	if (action.type === setInitialReduxState) {
}		}
action = {		action = {
...action,		...action,
payload: {		payload: {
...action.payload,		...action.payload,
keyserverIDs: newKeyserverIDs,		keyserverIDs: newKeyserverIDs,
},		},
};		};
} else if (
action.type === logOutActionTypes.success \|\|
action.type === deleteAccountActionTypes.success
) {
const { currentUserInfo, preRequestUserState } = action.payload;
if (
identityInvalidSessionDowngrade(
oldState,
currentUserInfo,
preRequestUserState,
)
) {
return {
...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
};
}		}

state = resetUserSpecificState(		if (
state,		action.type === logOutActionTypes.success \|\|
defaultWebState,		action.type === deleteAccountActionTypes.success \|\|
nonUserSpecificFieldsWeb,		action.type === identityRegisterActionTypes.success \|\|
);		(action.type === identityLogInActionTypes.success &&
} else if (action.type === identityRegisterActionTypes.success) {		action.payload.userID !== action.payload.preRequestUserState?.id)
state = resetUserSpecificState(
state,
defaultWebState,
nonUserSpecificFieldsWeb,
);
} else if (
action.type === identityLogInActionTypes.success &&
action.payload.userID !== action.payload.preRequestUserState?.id
) {		) {
state = resetUserSpecificState(		state = resetUserSpecificState(
state,		state,
defaultWebState,		defaultWebState,
nonUserSpecificFieldsWeb,		nonUserSpecificFieldsWeb,
);		);
}		}

▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines	(action.type === keyserverAuthActionTypes.success &&
state,		state,
action.payload.preRequestUserInfo,		action.payload.preRequestUserInfo,
action.payload.authActionSource,		action.payload.authActionSource,
))		))
) {		) {
return state;		return state;
}		}

		if (
		(action.type === logOutActionTypes.success \|\|
		action.type === deleteAccountActionTypes.success) &&
		identityInvalidSessionDowngrade(
		oldState,
		action.payload.currentUserInfo,
		action.payload.preRequestUserState,
		)
		) {
		return {
		...oldState,
		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
		};
		}

if (action.type === setInitialReduxState) {		if (action.type === setInitialReduxState) {
const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =		const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =
action.payload;		action.payload;
const replaceOperations: ReplaceKeyserverOperation[] = [];		const replaceOperations: ReplaceKeyserverOperation[] = [];
for (const keyserverID in keyserverInfos) {		for (const keyserverID in keyserverInfos) {
replaceOperations.push({		replaceOperations.push({
type: 'replace_keyserver',		type: 'replace_keyserver',
payload: {		payload: {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines	if (action.type === setInitialReduxState) {
}		}
action = {		action = {
...action,		...action,
payload: {		payload: {
...action.payload,		...action.payload,
keyserverIDs: newKeyserverIDs,		keyserverIDs: newKeyserverIDs,
},		},
};		};
} else if (
action.type === logOutActionTypes.success \|\|
action.type === deleteAccountActionTypes.success
) {
const { currentUserInfo, preRequestUserState } = action.payload;
if (
identityInvalidSessionDowngrade(
oldState,
currentUserInfo,
preRequestUserState,
)
) {
return {
...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
};
}		}

state = resetUserSpecificState(		if (
state,		action.type === logOutActionTypes.success \|\|
defaultWebState,		action.type === deleteAccountActionTypes.success \|\|
nonUserSpecificFieldsWeb,		action.type === identityRegisterActionTypes.success \|\|
);		(action.type === identityLogInActionTypes.success &&
} else if (action.type === identityRegisterActionTypes.success) {		action.payload.userID !== action.payload.preRequestUserState?.id)
state = resetUserSpecificState(
state,
defaultWebState,
nonUserSpecificFieldsWeb,
);
} else if (
action.type === identityLogInActionTypes.success &&
action.payload.userID !== action.payload.preRequestUserState?.id
) {		) {
state = resetUserSpecificState(		state = resetUserSpecificState(
state,		state,
defaultWebState,		defaultWebState,
nonUserSpecificFieldsWeb,		nonUserSpecificFieldsWeb,
);		);
}		}

▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines	(action.type === keyserverAuthActionTypes.success &&
state,		state,
action.payload.preRequestUserInfo,		action.payload.preRequestUserInfo,
action.payload.authActionSource,		action.payload.authActionSource,
))		))
) {		) {
return state;		return state;
}		}

		if (
		(action.type === logOutActionTypes.success \|\|
		action.type === deleteAccountActionTypes.success) &&
		identityInvalidSessionDowngrade(
		oldState,
		action.payload.currentUserInfo,
		action.payload.preRequestUserState,
		)
		) {
		return {
		...oldState,
		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
		};
		}

if (action.type === setInitialReduxState) {		if (action.type === setInitialReduxState) {
const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =		const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =
action.payload;		action.payload;
const replaceOperations: ReplaceKeyserverOperation[] = [];		const replaceOperations: ReplaceKeyserverOperation[] = [];
for (const keyserverID in keyserverInfos) {		for (const keyserverID in keyserverInfos) {
replaceOperations.push({		replaceOperations.push({
type: 'replace_keyserver',		type: 'replace_keyserver',
payload: {		payload: {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines	if (action.type === setInitialReduxState) {
}		}
action = {		action = {
...action,		...action,
payload: {		payload: {
...action.payload,		...action.payload,
keyserverIDs: newKeyserverIDs,		keyserverIDs: newKeyserverIDs,
},		},
};		};
} else if (
action.type === logOutActionTypes.success \|\|
action.type === deleteAccountActionTypes.success
) {
const { currentUserInfo, preRequestUserState } = action.payload;
if (
identityInvalidSessionDowngrade(
oldState,
currentUserInfo,
preRequestUserState,
)
) {
return {
...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
};
}		}

state = resetUserSpecificState(		if (
state,		action.type === logOutActionTypes.success \|\|
defaultWebState,		action.type === deleteAccountActionTypes.success \|\|
nonUserSpecificFieldsWeb,		action.type === identityRegisterActionTypes.success \|\|
);		(action.type === identityLogInActionTypes.success &&
} else if (action.type === identityRegisterActionTypes.success) {		action.payload.userID !== action.payload.preRequestUserState?.id)
state = resetUserSpecificState(
state,
defaultWebState,
nonUserSpecificFieldsWeb,
);
} else if (
action.type === identityLogInActionTypes.success &&
action.payload.userID !== action.payload.preRequestUserState?.id
) {		) {
state = resetUserSpecificState(		state = resetUserSpecificState(
state,		state,
defaultWebState,		defaultWebState,
nonUserSpecificFieldsWeb,		nonUserSpecificFieldsWeb,
);		);
}		}

▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines	(action.type === keyserverAuthActionTypes.success &&
state,		state,
action.payload.preRequestUserInfo,		action.payload.preRequestUserInfo,
action.payload.authActionSource,		action.payload.authActionSource,
))		))
) {		) {
return state;		return state;
}		}

		if (
		(action.type === logOutActionTypes.success \|\|
		action.type === deleteAccountActionTypes.success) &&
		identityInvalidSessionDowngrade(
		oldState,
		action.payload.currentUserInfo,
		action.payload.preRequestUserState,
		)
		) {
		return {
		...oldState,
		loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
		};
		}

if (action.type === setInitialReduxState) {		if (action.type === setInitialReduxState) {
const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =		const { userInfos, keyserverInfos, actualizedCalendarQuery, ...rest } =
action.payload;		action.payload;
const replaceOperations: ReplaceKeyserverOperation[] = [];		const replaceOperations: ReplaceKeyserverOperation[] = [];
for (const keyserverID in keyserverInfos) {		for (const keyserverID in keyserverInfos) {
replaceOperations.push({		replaceOperations.push({
type: 'replace_keyserver',		type: 'replace_keyserver',
payload: {		payload: {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines	if (action.type === setInitialReduxState) {
}		}
action = {		action = {
...action,		...action,
payload: {		payload: {
...action.payload,		...action.payload,
keyserverIDs: newKeyserverIDs,		keyserverIDs: newKeyserverIDs,
},		},
};		};
} else if (
action.type === logOutActionTypes.success \|\|
action.type === deleteAccountActionTypes.success
) {
const { currentUserInfo, preRequestUserState } = action.payload;
if (
identityInvalidSessionDowngrade(
oldState,
currentUserInfo,
preRequestUserState,
)
) {
return {
...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
};
}		}

state = resetUserSpecificState(		if (
state,		action.type === logOutActionTypes.success \|\|
defaultWebState,		action.type === deleteAccountActionTypes.success \|\|
nonUserSpecificFieldsWeb,		action.type === identityRegisterActionTypes.success \|\|
);		(action.type === identityLogInActionTypes.success &&
} else if (action.type === identityRegisterActionTypes.success) {		action.payload.userID !== action.payload.preRequestUserState?.id)
state = resetUserSpecificState(
state,
defaultWebState,
nonUserSpecificFieldsWeb,
);
} else if (
action.type === identityLogInActionTypes.success &&
action.payload.userID !== action.payload.preRequestUserState?.id
) {		) {
state = resetUserSpecificState(		state = resetUserSpecificState(
state,		state,
defaultWebState,		defaultWebState,
nonUserSpecificFieldsWeb,		nonUserSpecificFieldsWeb,
);		);
}		}

▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines