[lib] Queue operations
ClosedPublic
Actions

Authored by tomek on Sep 17 2024, 8:46 AM.

Details

Reviewers

kamil
will

Commits

rCOMMbda7f895b105: [lib] Queue operations

Summary

Dispatch appropriate action when an operation can be processed

https://linear.app/comm/issue/ENG-9189/introduce-additional-operation-queues

Depends on D13364

Test Plan

Tested the whole stack at once:

Created an operation with a reaction that was received before an operation creating the message
Created an operation with an edit that was received before an operation creating the message
Created an operation with an entry edit that was received before an operation creating the entry
Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 17 2024, 8:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 17 2024, 8:46 AM

tomek mentioned this in D13366: [lib] Update the conditions we check before processing the operations.Sep 17 2024, 8:47 AM

tomek added a child revision: D13366: [lib] Update the conditions we check before processing the operations.Sep 17 2024, 8:48 AM

Harbormaster completed remote builds in B31670: Diff 44275.Sep 17 2024, 9:06 AM

tomek requested review of this revision.Sep 17 2024, 9:06 AM

tomek edited the test plan for this revision. (Show Details)Sep 18 2024, 6:58 AM

kamil accepted this revision.Sep 18 2024, 9:44 AM

This revision is now accepted and ready to land.Sep 18 2024, 9:44 AM

Closed by commit rCOMMbda7f895b105: [lib] Queue operations (authored by tomek). · Explain WhySep 19 2024, 4:15 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMbda7f895b105: [lib] Queue operations.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-op-spec.js

3 lines

process-dm-ops.js

49 lines

Diff 44341

View Options

lib/shared/dm-ops/dm-op-spec.js

#pragma once		#pragma once

#include "../CryptoTools/Persist.h"		#include "../CryptoTools/Persist.h"
#include "entities/CommunityInfo.h"		#include "entities/CommunityInfo.h"
#include "entities/Draft.h"		#include "entities/Draft.h"
		#include "entities/IntegrityThreadHash.h"
#include "entities/KeyserverInfo.h"		#include "entities/KeyserverInfo.h"
#include "entities/Message.h"		#include "entities/Message.h"
#include "entities/MessageStoreThread.h"		#include "entities/MessageStoreThread.h"
#include "entities/MessageToDevice.h"		#include "entities/MessageToDevice.h"
#include "entities/OlmPersistAccount.h"		#include "entities/OlmPersistAccount.h"
#include "entities/OlmPersistSession.h"		#include "entities/OlmPersistSession.h"
#include "entities/PersistItem.h"		#include "entities/PersistItem.h"
#include "entities/Report.h"		#include "entities/Report.h"
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	public:
virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;		virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;
virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;		virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;
virtual void removeAllKeyservers() const = 0;		virtual void removeAllKeyservers() const = 0;
virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;		virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;
virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;		virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;
virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;		virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;
virtual void removeAllCommunities() const = 0;		virtual void removeAllCommunities() const = 0;
virtual std::vector<CommunityInfo> getAllCommunities() const = 0;		virtual std::vector<CommunityInfo> getAllCommunities() const = 0;
		virtual void replaceIntegrityThreadHashes(
		const std::vector<IntegrityThreadHash> &thread_hashes) const = 0;
		virtual void
		removeIntegrityThreadHashes(const std::vector<std::string> &ids) const = 0;
		virtual void removeAllIntegrityThreadHashes() const = 0;
		virtual std::vector<IntegrityThreadHash>
		getAllIntegrityThreadHashes() const = 0;
virtual void beginTransaction() const = 0;		virtual void beginTransaction() const = 0;
virtual void commitTransaction() const = 0;		virtual void commitTransaction() const = 0;
virtual void rollbackTransaction() const = 0;		virtual void rollbackTransaction() const = 0;
virtual int getContentAccountID() const = 0;		virtual int getContentAccountID() const = 0;
virtual int getNotifsAccountID() const = 0;		virtual int getNotifsAccountID() const = 0;
virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;		virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;
virtual std::optional<std::string>		virtual std::optional<std::string>
getOlmPersistAccountData(int accountID) const = 0;		getOlmPersistAccountData(int accountID) const = 0;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines