Page MenuHomePhabricator
Differential D13431

[native] Avoid Promise.allSettled
ClosedPublic
Actions

Authored by ashoat on Mon, Sep 23, 10:16 PM.
Tags
None
Referenced Files
F2844238: D13431.diff
Sun, Sep 29, 7:19 PM
F2842243: D13431.diff
Sun, Sep 29, 1:09 PM
F2841714: D13431.id44505.diff
Sun, Sep 29, 10:57 AM
Unknown Object (File)
Sat, Sep 28, 2:57 AM
Unknown Object (File)
Wed, Sep 25, 1:29 AM
Unknown Object (File)
Wed, Sep 25, 1:29 AM
Unknown Object (File)
Wed, Sep 25, 1:01 AM
Subscribers
tomek

Details

Reviewers
marcin
Commits
rCOMMe11444b5ba9d: [native] Avoid Promise.allSettled
Summary

This addresses ENG-9233, which was caused by Promise.allSettled being undefined on Android.

Depends on D13430

Test Plan

Confirmed that notifs sent from Android for a new session worked

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mon, Sep 23, 10:16 PM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 23, 10:16 PM
ashoat added a child revision: D13432: [native] Add log for when all_thread_members is used for a thread missing from ThreadStore.Mon, Sep 23, 10:18 PM
Harbormaster completed remote builds in B31788: Diff 44454.Mon, Sep 23, 10:32 PM
ashoat requested review of this revision.Mon, Sep 23, 10:32 PM
tomek added inline comments.Tue, Sep 24, 1:43 AM
lib/push/send-utils.js
996–1014

Can we add it to our utils /Users/palys/code/comm/lib/utils/promises.js?

marcin accepted this revision.Tue, Sep 24, 4:08 AM
This revision is now accepted and ready to land.Tue, Sep 24, 4:08 AM
ashoat added inline comments.Tue, Sep 24, 10:07 AM
lib/push/send-utils.js
996–1014

We could, but then we would have to maintain the types. I looked into this, and I'm a bit concerned because the types we'd need for our current version of Flow don't match the types in their main branch. This implies that we'd have to update it at some point... I'm not sure it's worth the effort

Closed by commit rCOMMe11444b5ba9d: [native] Avoid Promise.allSettled (authored by ashoat). · Explain WhyTue, Sep 24, 3:04 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe11444b5ba9d: [native] Avoid Promise.allSettled.

Revision Contents
Changeset List

PathSize
lib/
push/
20 lines

Diff 44454

View Options

lib/push/send-utils.js

Loading...