Page MenuHomePhabricator

[terraform] consolidate namespace and dimensions for current alarms/metrics
Changes PlannedPublic

Authored by will on Sep 25 2024, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 9:30 PM
Unknown Object (File)
Fri, Nov 1, 5:21 PM
Unknown Object (File)
Fri, Nov 1, 5:20 PM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Mon, Oct 21, 9:55 AM
Unknown Object (File)
Oct 16 2024, 12:46 PM
Unknown Object (File)
Oct 12 2024, 1:00 AM
Unknown Object (File)
Oct 7 2024, 5:10 PM
Subscribers

Details

Reviewers
bartek
varun
Summary

Under the suggestion of Bartek, we're consolidating our namespace and dimensions for our cloudwatch alarms and metrics

Depends on D13478

Test Plan

terraform plan

Diff Detail

Repository
rCOMM Comm
Branch
telemetry_tunnelbroker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Sep 25 2024, 4:16 PM
This revision is now accepted and ready to land.Sep 25 2024, 11:49 PM
services/terraform/remote/aws_cloudwatch_alarms.tf
99

Probably worth extracting this string value into locals - it's used extensively

Realized that memory and cpu utilization need to be in the AWS/ECS namespace to trigger as it looks like the metric needs to be resolved to this namespace. I think we can keep the Comm/ServiceLogs namespace for our own metrics (I'll do a test with alarms triggered by tracing errors and verify this), but we'll need to make to configure any alarms using AWS provided metrics with the proper default AWS namespace