[lib][native] fix farcaster outline icon and update CommIcons.ttf
ClosedPublic
Actions

Authored by varun on Wed, Sep 25, 5:08 PM.

Details

Reviewers

Commits

rCOMMb7a9f629e8bc: [lib][native] fix farcaster outline icon and update CommIcons.ttf

Summary

icon was off center and as a result looked a little strange on web. it also wasn't an outline like the other icons in the list. lastly, i forgot to include the updated CommIcons.ttf file, which we need to make the icon available on native

this diff re-centers the icon, makes it an outline, and updates CommIcons.ttf

Test Plan

icon looks correct now. CommIcons.ttf update is tested in next diff which actually uses it to display farcaster icon on native (android)

also tested that some of the existing CommIcon icons (e.g. "cloud-filled") still look right on native

Screenshot 2024-09-25 at 7.14.22 PM.png (966×828 px, 101 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Wed, Sep 25, 5:08 PM

varun held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Sep 25, 5:08 PM

varun added a child revision: D13476: [native] add farcaster icon on native.Wed, Sep 25, 5:09 PM

varun edited the test plan for this revision. (Show Details)Wed, Sep 25, 5:12 PM

varun attached a referenced file: F2810494: Screenshot 2024-09-25 at 7.14.22 PM.png. (Show Details)

varun edited the test plan for this revision. (Show Details)Wed, Sep 25, 5:19 PM

varun edited the summary of this revision. (Show Details)

varun edited the test plan for this revision. (Show Details)

will wait for CI to pass before landing

will accepted this revision.Wed, Sep 25, 5:24 PM

This revision is now accepted and ready to land.Wed, Sep 25, 5:24 PM

Harbormaster completed remote builds in B31861: Diff 44576.Wed, Sep 25, 5:26 PM

Closed by commit rCOMMb7a9f629e8bc: [lib][native] fix farcaster outline icon and update CommIcons.ttf (authored by varun). · Explain WhyWed, Sep 25, 5:29 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb7a9f629e8bc: [lib][native] fix farcaster outline icon and update CommIcons.ttf.

Revision Contents
Changeset List

Path

Size

lib/

shared/

comm-icon-config.json

4 lines

native/

fonts/

CommIcons.ttf

Diff 44576

View Options

lib/shared/comm-icon-config.json