[identity] Validate username prefix queries with identity search
ClosedPublic
Actions

Authored by will on Mon, Sep 30, 3:31 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMe4f6df2e0669: [identity] Validate username prefix queries with identity search

Summary

This validates whether username prefixes are valid using regex. If not, we return an empty vector of results

Test Plan

Ended up testing this on staging with a local iOS simulator app connecting to staging identity and running queries. No changes in functionality. Tested with special characters, regular usernames, and ethereum addresses.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Mon, Sep 30, 3:31 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Sep 30, 3:31 PM

Harbormaster completed remote builds in B31944: Diff 44701.Mon, Sep 30, 3:48 PM

will requested review of this revision.Mon, Sep 30, 3:48 PM

remove code dup

Harbormaster completed remote builds in B31946: Diff 44703.Mon, Sep 30, 4:40 PM

bartek accepted this revision.Tue, Oct 1, 1:01 AM

This revision is now accepted and ready to land.Tue, Oct 1, 1:01 AM

Closed by commit rCOMMe4f6df2e0669: [identity] Validate username prefix queries with identity search (authored by will). · Explain WhyTue, Oct 1, 10:14 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMe4f6df2e0669: [identity] Validate username prefix queries with identity search.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

mod.rs

11 lines

Diff 44785

View Options

services/identity/src/websockets/mod.rs

[identity] Validate username prefix queries with identity searchClosedPublicActions